Page MenuHomePhabricator
Create Task
Maniphest T269626

Remove deprecated mediawiki.skinning.content.externallinks module
Closed, ResolvedPublic
Actions

Description

The mediawiki.skinning.content.externallinks module is deprecated.

Impacted skins should use ResourceLoaderSkinModule following the example in Monobook

If no action is taken the module will eventually be removed and styles for icons that show up against links will no longer function in the skin.

Also: https://github.com/femiwiki/FemiwikiSkin/issues/210

TODO

  • Provide patches for all impacted skins
  • Remove the module

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: MacFan4000. · View Herald TranscriptDec 7 2020, 8:24 PM
Jdlrobson mentioned this in T267577: Deprecate and remove external links CSS module from core.Dec 7 2020, 8:25 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Backlog to Phase 4 - Standardize ResourceLoaderSkinModules styling rules on the MediaWiki-Core-Skin-Architecture board.Dec 8 2020, 7:54 PM
Jdlrobson moved this task from Phase 4 - Standardize ResourceLoaderSkinModules styling rules to It's complicated on the MediaWiki-Core-Skin-Architecture board.
gerritbot added a comment.Dec 9 2020, 8:40 PM

Change 647359 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/BlueSky@master] Use skin features for external links and junk

https://gerrit.wikimedia.org/r/647359

gerritbot added a project: Patch-For-Review.Dec 9 2020, 8:40 PM
gerritbot added a comment.Dec 9 2020, 10:10 PM

Change 647359 merged by jenkins-bot:
[mediawiki/skins/BlueSky@master] Use skin features for external links and junk

https://gerrit.wikimedia.org/r/647359

Jdlrobson removed a project: BlueSky.Dec 9 2020, 10:14 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 9 2020, 11:10 PM
gerritbot added a comment.Dec 10 2020, 11:59 PM

Change 647848 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/GreyStuff@master] Use newfangled stuff

https://gerrit.wikimedia.org/r/647848

gerritbot added a project: Patch-For-Review.Dec 10 2020, 11:59 PM
gerritbot added a comment.Dec 12 2020, 8:39 PM

Change 647848 merged by jenkins-bot:
[mediawiki/skins/GreyStuff@master] Use newfangled stuff

https://gerrit.wikimedia.org/r/647848

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2020, 9:10 PM
Isarra removed a project: GreyStuff.Dec 12 2020, 10:18 PM
gerritbot added a comment.Dec 16 2020, 6:12 AM

Change 649769 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/WoOgLeShades@master] Use skinfeatures and updated skin functions

https://gerrit.wikimedia.org/r/649769

gerritbot added a project: Patch-For-Review.Dec 16 2020, 6:12 AM
gerritbot added a comment.Dec 16 2020, 5:00 PM

Change 649769 merged by jenkins-bot:
[mediawiki/skins/WoOgLeShades@master] Use skinfeatures and updated skin functions

https://gerrit.wikimedia.org/r/649769

Jdlrobson removed a project: WoOgLeShades.Dec 16 2020, 6:47 PM
gerritbot added a comment.Dec 17 2020, 10:16 PM

Change 650274 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/HasSomeColours@master] Use updated everything

https://gerrit.wikimedia.org/r/650274

gerritbot added a comment.Dec 17 2020, 10:59 PM

Change 650274 merged by jenkins-bot:
[mediawiki/skins/HasSomeColours@master] Use updated everything

https://gerrit.wikimedia.org/r/650274

Isarra removed a project: HasSomeColours.Dec 17 2020, 11:03 PM
Isarra mentioned this in rSHAS7ea7e3ff6228: Use updated everything.Dec 17 2020, 11:16 PM
Isarra removed a project: MediaWiki-skins-Amethyst.Dec 22 2020, 7:07 PM
gerritbot added a comment.Mar 17 2021, 9:02 PM

Change 673104 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Anisa@master] Use updated/core wodgits and bump required mw version to 1.35

https://gerrit.wikimedia.org/r/673104

Jdlrobson removed a project: Anisa.Mar 17 2021, 9:59 PM
Isarra added a project: Anisa.Mar 17 2021, 11:27 PM
Isarra subscribed.

Not removing this from Anisa yet after all, as the replacement apparently isn't available in 1.35, and Anisa is still targeting 1.35 and not 1.36... is this still only deprecated as of an unreleased version, or something?

Frankly it's probably gonna have to go back into branches for a whole lot of skins anyway given 1.35 is the LTS, ugggghh.

Isarra added a comment.Mar 20 2021, 11:13 PM

Duuur I'm an idiot, I just need to copy the 1.35 fix out of timeless, huh.

Isarra removed a project: Anisa.Mar 21 2021, 4:22 AM

Sorry about that, it turns out some of us are just drunk and sleep deprived and that doesn't result in the most meaningful testing...

Jdlrobson moved this task from It's complicated to 1.37 release on the MediaWiki-Core-Skin-Architecture board.Jul 13 2021, 11:47 PM
Jdlrobson moved this task from 1.37 release to 1.38 deprecations on the MediaWiki-Core-Skin-Architecture board.Aug 3 2021, 12:16 AM
Jdlrobson triaged this task as High priority.EditedOct 6 2021, 3:44 PM

We should remove this module. Module definitions in core hurt performance. No need to patch since a missing ResourceLoader module will not cause a fatal. We can open tickets after this has happened.

Jdlrobson renamed this task from mediawiki.skinning.content.externallinks is deprecated to Remove deprecated mediawiki.skinning.content.externallinks module.Oct 8 2021, 2:46 PM
Jdlrobson moved this task from 1.38 deprecations to Deprecations and removals on the MediaWiki-Core-Skin-Architecture board.Dec 14 2021, 6:59 PM
Volker_E added a parent task: T304322: Remove 6 deprecated ResourceLoader skin modules in core.Mar 22 2022, 5:07 PM
Volker_E subscribed.Mar 22 2022, 8:48 PM
Restricted Application added a subscriber: Lens0021. · View Herald TranscriptMar 22 2022, 8:48 PM
Volker_E awarded a token.Mar 22 2022, 10:49 PM
Jdlrobson added a project: MW-1.39-release.Mar 29 2022, 2:29 AM
Jdforrester-WMF moved this task from Blocker to To deprecate or remove on the MW-1.39-release board.Mar 30 2022, 3:21 PM
Jdlrobson mentioned this in T304322: Remove 6 deprecated ResourceLoader skin modules in core.May 16 2022, 5:09 PM
Jdlrobson updated the task description. (Show Details)Jun 6 2022, 7:34 PM
Jdlrobson added projects: patch-welcome, good first task.
gerritbot added a comment.Aug 11 2022, 10:48 AM

Change 822341 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Remove mediawiki.skinning.content.externallinks

https://gerrit.wikimedia.org/r/822341

gerritbot added a comment.Aug 12 2022, 6:20 AM

Change 822341 merged by jenkins-bot:

[mediawiki/core@master] Remove mediawiki.skinning.content.externallinks

https://gerrit.wikimedia.org/r/822341

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 12 2022, 7:01 AM
Jdlrobson removed projects: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Patch-For-Review.Aug 12 2022, 9:15 AM

Not a blocker for mediawiki 1.39. Patches welcome for the non production skins.

Jdlrobson removed a project: MediaWiki-Core-Skin-Architecture.Aug 15 2022, 10:44 AM

(Fix done in core)

gerritbot added a comment.Sep 14 2022, 6:31 PM

Change 832305 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/WPtouch@master] Update for 1.39

https://gerrit.wikimedia.org/r/832305

gerritbot added a project: Patch-For-Review.Sep 14 2022, 6:31 PM
gerritbot added a comment.Sep 14 2022, 7:15 PM

Change 832313 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/WPtouch@REL1_39] Update for 1.39

https://gerrit.wikimedia.org/r/832313

gerritbot added a comment.Sep 14 2022, 7:17 PM

Change 832305 merged by jenkins-bot:

[mediawiki/skins/WPtouch@master] Update for 1.39

https://gerrit.wikimedia.org/r/832305

gerritbot added a comment.Sep 15 2022, 4:46 PM

Change 832527 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Refreshed@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832527

gerritbot added a comment.Sep 15 2022, 4:56 PM

Change 832528 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Nimbus@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832528

gerritbot added a comment.Sep 15 2022, 4:57 PM

Change 832325 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Refreshed@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832325

gerritbot added a comment.Sep 15 2022, 4:59 PM

Change 832325 merged by jenkins-bot:

[mediawiki/skins/Refreshed@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832325

gerritbot added a comment.Sep 15 2022, 4:59 PM

Change 832527 merged by jenkins-bot:

[mediawiki/skins/Refreshed@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832527

gerritbot added a comment.Sep 15 2022, 5:02 PM

Change 832546 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Nimbus@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832546

gerritbot added a comment.Sep 15 2022, 5:04 PM

Change 832546 merged by jenkins-bot:

[mediawiki/skins/Nimbus@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832546

Jdlrobson mentioned this in R1893:645b90795d38: Upgrade for 1.39.Sep 15 2022, 5:17 PM
Jdlrobson mentioned this in R1893:4bafcb3a0886: Upgrade for 1.39.
gerritbot added a comment.Sep 16 2022, 2:35 PM

Change 832528 merged by Jdlrobson:

[mediawiki/skins/Nimbus@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832528

gerritbot added a comment.Sep 16 2022, 3:01 PM

Change 832648 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/DuskToDawn@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832648

gerritbot added a comment.Sep 16 2022, 3:05 PM

Change 832649 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Dusk@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832649

gerritbot added a comment.Sep 16 2022, 3:10 PM

Change 832651 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/DeskMessMirrored@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832651

gerritbot added a comment.Sep 16 2022, 3:14 PM

Change 832653 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Bouquet@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832653

gerritbot added a comment.Sep 16 2022, 3:16 PM

Change 832667 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Bouquet@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832667

gerritbot added a comment.Sep 16 2022, 3:17 PM

Change 832668 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Dusk@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832668

gerritbot added a comment.Sep 16 2022, 3:17 PM

Change 832669 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/DuskToDawn@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832669

gerritbot added a comment.Sep 16 2022, 3:19 PM

Change 832669 merged by jenkins-bot:

[mediawiki/skins/DuskToDawn@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832669

gerritbot added a comment.Sep 16 2022, 3:20 PM

Change 832668 merged by jenkins-bot:

[mediawiki/skins/Dusk@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832668

gerritbot added a comment.Sep 16 2022, 3:20 PM

Change 832667 merged by jenkins-bot:

[mediawiki/skins/Bouquet@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832667

gerritbot added a comment.Sep 16 2022, 3:21 PM

Change 832670 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/DeskMessMirrored@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832670

gerritbot added a comment.Sep 16 2022, 3:24 PM

Change 832670 merged by jenkins-bot:

[mediawiki/skins/DeskMessMirrored@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832670

gerritbot added a comment.Sep 16 2022, 3:24 PM

Change 832655 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Anisa@master] Do not use deprecated external links module

https://gerrit.wikimedia.org/r/832655

gerritbot added a comment.Sep 16 2022, 3:25 PM

Change 832671 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Anisa@REL1_39] Do not use deprecated external links module

https://gerrit.wikimedia.org/r/832671

gerritbot added a comment.Sep 16 2022, 3:31 PM

Change 832653 merged by jenkins-bot:

[mediawiki/skins/Bouquet@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832653

gerritbot added a comment.Sep 16 2022, 3:31 PM

Change 832649 merged by jenkins-bot:

[mediawiki/skins/Dusk@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832649

gerritbot added a comment.Sep 16 2022, 3:31 PM

Change 832648 merged by jenkins-bot:

[mediawiki/skins/DuskToDawn@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832648

gerritbot added a comment.Sep 16 2022, 3:31 PM

Change 832651 merged by jenkins-bot:

[mediawiki/skins/DeskMessMirrored@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832651

gerritbot added a comment.Sep 16 2022, 3:34 PM

Change 832655 merged by Jdlrobson:

[mediawiki/skins/Anisa@master] Do not use deprecated external links module

https://gerrit.wikimedia.org/r/832655

Jdlrobson mentioned this in rSANIdeb461d70491: Do not use deprecated external links module.Sep 16 2022, 3:34 PM
gerritbot added a comment.Sep 16 2022, 3:36 PM

Change 832671 merged by jenkins-bot:

[mediawiki/skins/Anisa@REL1_39] Do not use deprecated external links module

https://gerrit.wikimedia.org/r/832671

Jdlrobson closed this task as Resolved.Sep 16 2022, 3:36 PM
Jdlrobson claimed this task.
Jdlrobson updated the task description. (Show Details)
Jdlrobson edited projects, added MediaWiki-Core-Skin-Architecture; removed WPtouch, Refreshed, Nimbus, Mask, Gamepress, DuskToDawn, Dusk, DeskMessMirrored, Bouquet.

I've patched all skins on Gerrit, and backported
I've left issues on all projects where we don't have push rights to the code.
(Mask fixed in 6c214786f004bf51ccef9df4d283e5665a9a5eab)

Jdlrobson mentioned this in rSANIdd2246e94918: Do not use deprecated external links module.Sep 16 2022, 3:36 PM
Volker_E added a comment.Sep 16 2022, 8:31 PM

Thanks @Jdlrobson for this Herculean effort! 👏

gerritbot added a comment.Sep 16 2022, 9:38 PM

Change 832313 merged by jenkins-bot:

[mediawiki/skins/WPtouch@REL1_39] Update for 1.39

https://gerrit.wikimedia.org/r/832313

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL