Mobile menus currently only render with js. Given unusually high mobile breakpoints, this is particularly not good.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Implement nojs menus for mobile | mediawiki/skins/GreyStuff | master | +65 -0 |
Related Objects
Event Timeline
FYI In Vector and Minerva we use a checkbox hack for the menus. We've been meaning to consolidate the associated CSS code as a core module.
Take a look at their code and let me know if something in core based on them would help this.
I thought the purpose of the checkboxes was so there'd be accessible toggles for folks not using normal input (mouse/touch), and the like, js or otherwise? Unfortunately I don't really understand it, so I have a bunch of skins here that just don't support this use case I can't figure out how to replicate to begin with... is there, like, some actual documentation/guidelines on this somewhere?
Change 673645 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/GreyStuff@master] Implement nojs menus for mobile
Change 673645 merged by jenkins-bot:
[mediawiki/skins/GreyStuff@master] Implement nojs menus for mobile
No documentation I'm afraid - just code examples in the Pandora, Minerva and Vector skins.