Page MenuHomePhabricator
Create Task
Maniphest T273118

Help panel: Remove dependency on Help Desk title existing
Closed, ResolvedPublic
Actions

Description

The "help desk" (place where help panel posted questions to) used to be an integral part of the help panel experience. But the help panel has evolved -- it's now a conduit for showing guidance when editing, on some wikis it posts to your mentor and not the help desk, etc.

The code for the help panel contains a check to see if the configured help desk title exists, and if not, it won't display. This means for suggested edits, the user won't see guidance, as was the case on Korean wiki this month (T239695).

My proposal is to remove the check for help desk title existence. Instead, we can still show the help panel but we will just hide the section that allows asking questions (unless it's configured to post to a mentor page, that is)

Details

SubjectRepoBranchLines +/-
GrowthExperiments: Do not expect help desk is definedmediawiki/extensions/WikimediaEventsmaster+3 -1
cleanup: Remove help panel URL from Help homepage modulemediawiki/extensions/GrowthExperimentsmaster+0 -5
cleanup: Remove help panel URL from Help homepage modulemediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.33+0 -5
Help panel: Do not require help desk to be configuredmediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.32+35 -23
Help panel: Do not require help desk to be configuredmediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.33+35 -23
Help panel: Do not require help desk to be configuredmediawiki/extensions/GrowthExperimentsmaster+35 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Jan 27 2021, 10:14 PM
Restricted Application added subscribers: revi, Aklapper. · View Herald TranscriptJan 27 2021, 10:14 PM
revi added a comment.Jan 28 2021, 12:32 PM

Note: The pages for Jan~Feb was created by someone @ Korean Wikipedia
Community, so I just created for the remainder of 2021.

There was no failure, as kowiki had a functional helpdesk pages for each
week of Jan existed since December 2020, and Feb since January 2021.

kostajh added a comment.Jan 28 2021, 1:18 PM
In T273118#6783660, @revi wrote:

Note: The pages for Jan~Feb was created by someone @ Korean Wikipedia
Community, so I just created for the remainder of 2021.

There was no failure, as kowiki had a functional helpdesk pages for each
week of Jan existed since December 2020, and Feb since January 2021.

Ah, thanks for clarifying. I saw the task about creating help pages, checked if the help panel loaded on my mobile device (it didn’t) and then I checked on desktop after I thought the help pages were created and saw the help panel worked. Hence my assumption that there was some breakage.

However I currently don’t see the help panel on kowiki with my mobile device so something else must be going on.

Urbanecm_WMF mentioned this in T273799: The help panel at kowiki does not load.Feb 3 2021, 5:59 PM
kostajh mentioned this in T273773: Scale: ability to deploy without help desk feature.Feb 3 2021, 5:59 PM
Urbanecm_WMF added a parent task: T273773: Scale: ability to deploy without help desk feature.Feb 3 2021, 6:00 PM
Urbanecm_WMF mentioned this in T273776: Scale: ability to deploy without mentorship module.Feb 17 2021, 4:49 PM
Urbanecm_WMF mentioned this in T275908: Scale: default to mentorship questions from help panel.Mar 1 2021, 8:52 PM
Urbanecm_WMF added a parent task: T275908: Scale: default to mentorship questions from help panel.Mar 2 2021, 5:41 PM
Urbanecm_WMF claimed this task.Mar 2 2021, 11:22 PM
Urbanecm_WMF triaged this task as Medium priority.
Restricted Application added a project: User-Urbanecm_WMF. · View Herald TranscriptMar 2 2021, 11:22 PM
gerritbot added a comment.Mar 2 2021, 11:34 PM

Change 667960 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Help panel: Do not require help desk to be configured

https://gerrit.wikimedia.org/r/667960

gerritbot added a project: Patch-For-Review.Mar 2 2021, 11:34 PM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)), User-Urbanecm_WMF (Engineering); removed User-Urbanecm_WMF, Growth-Team.Mar 2 2021, 11:35 PM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.Mar 2 2021, 11:49 PM
gerritbot added a comment.Mar 3 2021, 4:51 PM

Change 667960 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: Do not require help desk to be configured

https://gerrit.wikimedia.org/r/667960

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 3 2021, 4:52 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 3 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 3 2021, 5:11 PM
gerritbot added a comment.Mar 3 2021, 7:30 PM

Change 668149 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.33] Help panel: Do not require help desk to be configured

https://gerrit.wikimedia.org/r/668149

gerritbot added a project: Patch-For-Review.Mar 3 2021, 7:30 PM

Change 668150 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.32] Help panel: Do not require help desk to be configured

https://gerrit.wikimedia.org/r/668150

gerritbot added a comment.Mar 3 2021, 7:43 PM

Change 668149 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.33] Help panel: Do not require help desk to be configured

https://gerrit.wikimedia.org/r/668149

gerritbot added a comment.Mar 3 2021, 7:43 PM

Change 668150 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.32] Help panel: Do not require help desk to be configured

https://gerrit.wikimedia.org/r/668150

Stashbot added a comment.Mar 3 2021, 7:53 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-03T19:53:26Z] <urbanecm@deploy1002> Synchronized php-1.36.0-wmf.32/extensions/GrowthExperiments/: a036d9fa10fb522279bd5b7f2c0a14e1de7bb0ae: Help panel: Do not require help desk to be configured (T273118) (duration: 01m 10s)

Stashbot added a comment.Mar 3 2021, 7:57 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-03T19:57:40Z] <urbanecm@deploy1002> Synchronized php-1.36.0-wmf.33/extensions/GrowthExperiments/: 4cba1843591dc689ade47aab700a47134b8c15c4: Help panel: Do not require help desk to be configured (T273118) (duration: 01m 10s)

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.33; 2021-03-02); removed MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 3 2021, 8:00 PM
gerritbot added a comment.Mar 4 2021, 7:35 PM

Change 668539 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove help panel URL from Help homepage module

https://gerrit.wikimedia.org/r/668539

gerritbot added a comment.Mar 4 2021, 7:46 PM

Change 668511 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.33] cleanup: Remove help panel URL from Help homepage module

https://gerrit.wikimedia.org/r/668511

kostajh added a comment.Mar 4 2021, 7:51 PM

This code exists in WikimediaEvents extension:

return ExtensionRegistry::getInstance()->isLoaded( 'GrowthExperiments' ) &&
			$config->get( 'GEHelpPanelEnabled' ) &&
			$config->get( 'GEHelpPanelHelpDeskTitle' ) &&
			HelpPanel::getHelpDeskTitle( $config )->isValid();

You'd have to remove the two $config->get() checks to get to a breakage, so maybe it's fine as is, but we might want to confirm that we have a Title before calling isValid() just to be safe.

gerritbot added a comment.Mar 4 2021, 7:59 PM

Change 668539 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove help panel URL from Help homepage module

https://gerrit.wikimedia.org/r/668539

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.34; 2021-03-09); removed MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 4 2021, 8:00 PM
gerritbot added a comment.Mar 4 2021, 8:03 PM

Change 668511 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.33] cleanup: Remove help panel URL from Help homepage module

https://gerrit.wikimedia.org/r/668511

Stashbot mentioned this in T276450: Deploy Growth features on Hindi Wikipedia.Mar 4 2021, 8:08 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-04T20:08:43Z] <urbanecm@deploy1002> Synchronized php-1.36.0-wmf.33/extensions/GrowthExperiments/includes/HomepageModules/Help.php: 8cc65e3fd0b4a75599171b619108584526784853: cleanup: Remove help panel URL from Help homepage module (T276450; T273118) (duration: 00m 58s)

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.33; 2021-03-02); removed MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 4 2021, 9:00 PM
Etonkovidova mentioned this in T276634: [wmf.33-regression] Homepage: "Ask your mentor" panel displayed short.Mar 5 2021, 11:19 PM
Etonkovidova closed this task as Resolved.Mar 5 2021, 11:27 PM
Etonkovidova subscribed.

I'm closing this task as Resolved (tentatively) since there is T276634: [wmf.33-regression] Homepage: "Ask your mentor" panel displayed short which might be caused by one of the patches for this task (it seems unlikely though).

Urbanecm_WMF reopened this task as Open.Mar 5 2021, 11:51 PM

Reopening per kosta's comment, which still needs to be addressed.

kostajh mentioned this in T276759: TypeError: title is undefined.Mar 8 2021, 9:38 AM
gerritbot added a comment.Mar 9 2021, 3:00 AM

Change 670023 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/WikimediaEvents@master] GrowthExperiments: Do not expect help desk is defined

https://gerrit.wikimedia.org/r/670023

Etonkovidova moved this task from QA to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 15 2021, 8:52 PM
Etonkovidova added a comment.Mar 19 2021, 7:49 PM

There is one edge case to check:

  • a wiki has the Mentorship module
  • Help panel is not enabled in Preferences

Then, there will be the issue described in T276634: [wmf.33-regression] Homepage: "Ask your mentor" panel displayed short

Screen Shot 2021-03-05 at 3.01.34 PM.png (659×1 px, 239 KB)

Could be there wikis that do have Mentorship but not Help desk? Or could there be the cases when Help panel is not enabled in Preferences (not counting the cases when users do not enabled it when enabling Homepage manually)?

Urbanecm_WMF added a comment.Mar 19 2021, 8:51 PM

Hello,

Wikis are no longer required (or even encouraged!) to provide a help desk.
Mentorship is the only question asking mechanism that wikis are encouraged
to use right now. So yes, wikis with mentorship and no help panel are
pretty common, and will be even more common in the future.

Afaik, the software never automatically enables only homepage or only help
panel. The only way that can happen is when an user manually changes their
preferences. But even in that case, I don't see why there should be any
error happening?

Urbanecm_WMF moved this task from Code Review to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 12 2021, 9:35 PM
Urbanecm_WMF moved this task from In review to Later on the User-Urbanecm_WMF (Engineering) board.Apr 14 2021, 5:25 PM
Urbanecm_WMF edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:48 PM
• Rileych removed a project: Growth-Team-Filtering.Apr 20 2021, 4:33 PM
MMiller_WMF subscribed.Aug 17 2021, 2:29 PM

@Urbanecm_WMF -- could you please update or move this task to the appropriate place? It seems to have been stuck for several months.

gerritbot added a comment.Aug 17 2021, 5:29 PM

Change 670023 abandoned by Urbanecm:

[mediawiki/extensions/WikimediaEvents@master] GrowthExperiments: Do not expect help desk is defined

Reason:

let's leave this as-is for now

https://gerrit.wikimedia.org/r/670023

Urbanecm_WMF closed this task as Resolved.Aug 17 2021, 5:30 PM
Urbanecm_WMF removed a project: Patch-Needs-Improvement.

I think this task can be closed for now. Help desk is no longer configured on most of the wikis, and the code worked fine. As Kosta mentioned, the code would need to be changed to get a breakage. Patch abandoned, task closed. Thanks for the reminder!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL