Maniphest T281710

Make PropertyOrderProviderTest a proper unit test
Closed, ResolvedPublic
Actions

Description

The WikibaseClient.PropertyOrderProvider service wiring uses the ObjectCache::getLocalClusterInstance() function, which means that the unit test for that service wiring actually can’t run without MediaWiki being set up, because ObjectCache::getLocalClusterInstance() uses MediaWiki globals and the default service container.

A solution for this almost certainly requires T243233: MediaWiki should provide a LocalClusterObjectCache service.

See also: T281706, T281708.

To reproduce:

composer phpunit extensions/Wikibase/client/tests/phpunit/unit/includes/ServiceWiring/PropertyOrderProviderTest.php

Details

	Subject	Repo	Branch	Lines +/-
	Use ObjectCacheFactory in PropertyOrderProvider service wiring	mediawiki/extensions/Wikibase	master	+11 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T108946 [Epic] Improve the development infrastructure
		Open		None	T84948 MediaWiki core unit tests should be true unit tests (tracking)
		Open		None	T96458 Separate Wikibase unit tests from integration tests
		Resolved		kostajh	T266441 MediaWikiUnitTestCase should prevent access to MediaWikiServices
		Stalled		None	T277464 [EPIC] Multiple Wikibase service wiring tests fail when run as unit tests
		Open		Collins	T363770 Replace deprecated ObjectCache factory methods in Wikimedia deployed code
		Open		None	T361949 [SW] [REPO][CLIENT] Use ObjectCacheFactory in Wikibase
		Resolved		• Lucas_Werkmeister_WMDE	T281710 Make PropertyOrderProviderTest a proper unit test

Event Timeline

• Lucas_Werkmeister_WMDE created this task.May 3 2021, 1:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2021, 1:17 PM

• Lucas_Werkmeister_WMDE mentioned this in T277464: [EPIC] Multiple Wikibase service wiring tests fail when run as unit tests.May 3 2021, 1:18 PM

• Lucas_Werkmeister_WMDE updated the task description. (Show Details)May 3 2021, 3:43 PM

• Lucas_Werkmeister_WMDE updated the task description. (Show Details)

• Lucas_Werkmeister_WMDE mentioned this in T281708: Make OtherProjectsSitesProviderTest a proper unit test.

• Lucas_Werkmeister_WMDE mentioned this in T281706: Make ViewFactoryTest a proper unit test.

Addshore added a project: [DEPRECATED] wdwb-tech.Sep 21 2021, 10:49 AM

Addshore moved this task from Inbox to Subtasks on the [DEPRECATED] wdwb-tech board.

• Lucas_Werkmeister_WMDE mentioned this in T291706: Make WikibaseRepo.BagOStuffSiteLinkConflictLookup a proper unit test.Sep 24 2021, 4:58 PM

• Lucas_Werkmeister_WMDE mentioned this in T361949: [SW] [REPO][CLIENT] Use ObjectCacheFactory in Wikibase.Apr 5 2024, 2:38 PM

• Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mon, May 27, 3:39 PM

Change #1036291 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use ObjectCacheFactory in PropertyOrderProvider service wiring

https://gerrit.wikimedia.org/r/1036291

gerritbot added a project: Patch-For-Review.Mon, May 27, 3:39 PM

• Lucas_Werkmeister_WMDE claimed this task.Mon, May 27, 3:39 PM

• Lucas_Werkmeister_WMDE added a parent task: T361949: [SW] [REPO][CLIENT] Use ObjectCacheFactory in Wikibase.Mon, May 27, 3:43 PM

• Lucas_Werkmeister_WMDE removed • Lucas_Werkmeister_WMDE as the assignee of this task.Tue, May 28, 8:35 AM

• Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed [DEPRECATED] wdwb-tech.

• Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.

ArthurTaylor claimed this task.Tue, May 28, 8:40 AM

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Tue, May 28, 8:52 AM

ArthurTaylor moved this task from In Peer Review to Ready for Tech Verification on the Wikidata Dev Team (Wikidata.org Slice) board.

ArthurTaylor subscribed.

Change #1036291 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use ObjectCacheFactory in PropertyOrderProvider service wiring

https://gerrit.wikimedia.org/r/1036291

• Lucas_Werkmeister_WMDE closed this task as Resolved.Tue, May 28, 10:20 AM

• Lucas_Werkmeister_WMDE claimed this task.

• Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.

Maintenance_bot removed a project: Patch-For-Review.Tue, May 28, 10:30 AM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).Tue, May 28, 1:01 PM