Page MenuHomePhabricator

ISA tool uses third party cdn
Open, Needs TriagePublic

Description

isa/templates/campaign/campaigns.html and isa/templates/main/layout.html loads scripts from https://cdn.datatables.net. These should be changed to point to https://cdnjs.toolforge.org/ instead

Event Timeline

we currently use v. 1.10.18, but toolforge only hosts 1.10.21. It's unclear to me if there are any differences which would affect us.

Change 879078 had a related patch set uploaded (by Eugene233; author: Eugene233):

[labs/tools/Isa@master] ISA tool uses third party cdn

https://gerrit.wikimedia.org/r/879078

Change 950016 had a related patch set uploaded (by Eugene233; author: Eugene233):

[labs/tools/Isa@m2c] ISA tool uses third party cdn

https://gerrit.wikimedia.org/r/950016

Change 879078 abandoned by Eugene233:

[labs/tools/Isa@master] ISA tool uses third party cdn

Reason:

In favor of https://gerrit.wikimedia.org/r/c/labs/tools/Isa/+/879078

https://gerrit.wikimedia.org/r/879078

Change 952804 had a related patch set uploaded (by Sebastian Berlin (WMSE); author: Eugene233):

[labs/tools/Isa@m2c-rollback] ISA tool uses third party cdn

https://gerrit.wikimedia.org/r/952804

Change 954642 had a related patch set uploaded (by Eugene233; author: Eugene233):

[labs/tools/Isa@main] ISA tool uses third party cdn

https://gerrit.wikimedia.org/r/954642

Change 952804 abandoned by Eugene233:

[labs/tools/Isa@m2c-rollback] ISA tool uses third party cdn

Reason:

cherry picked on main

https://gerrit.wikimedia.org/r/952804

Change 950016 abandoned by Eugene233:

[labs/tools/Isa@m2c] ISA tool uses third party cdn

Reason:

Cherry picked to new main branch

https://gerrit.wikimedia.org/r/950016