Page MenuHomePhabricator

Language count is updated before publish in about widget
Open, LowPublic

Description

When adding information in another language

CleanShot 2023-09-11 at 12.33.10@2x.png (1×1 px, 216 KB)

the language count is updated before publish

CleanShot 2023-09-11 at 12.34.23@2x.png (1×1 px, 184 KB)

The count should be updated instead only after publish.

After pressing the "Publish" button, the language count goes back to previous state ("4 languages" in the example above) before the automatic page refresh, displaying then the correct number.

Event Timeline

Why do you think this should work this way? This proposal would mean that some bits of the UX (just this?) are inconsistent with the rest of the page.

Why do you think this should work this way? This proposal would mean that some bits of the UX (just this?) are inconsistent with the rest of the page.

that's a good question! on a second thought, i do think it's correct to update the language count before publish (you indeed just added a language).

probably the question should be: should the count stay the same during the whole flow? right now we update the language count when you move from the about dialog to the publish dialog, but after pressing the "Publish" button the count turns back to the value before your contribution. then, after the automatic page refresh, the count turns back to "correct" value.

a-ha! while writing this, i was testing different scenarios, and i've found out that this "issue" only happens when you edit the labels while in "Read" mode. when editing in "Edit" mode everything looks sharp!

read-vs-edit-add-language.jpg (2×10 px, 2 MB)

DVrandecic added a project: Design.
DVrandecic moved this task from Needs Product/Design to Backlog on the Abstract Wikipedia team board.

To confirm, this is still occurring and we still want to make this change when in 'Read' mode bc it is fine in 'Edit' mode?

To confirm, this is still occurring and we still want to make this change when in 'Read' mode bc it is fine in 'Edit' mode?

yes correct, we'd like to understand if it's possible to keep the language count consistent during the publishing flow. the image below does not preview, but if you open you can see the issue step-by-step. basically, once you add a new language in read mode, and click on "Publish", the language count goes back to the previous number, then the page auto refresh, and it then displays the correct count.

read-vs-edit-add-language.jpg (2×10 px, 2 MB)

Change #1030061 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Only revert multilingual data if the changes are not saved

https://gerrit.wikimedia.org/r/1030061

Change #1030061 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Only revert multilingual data if the changes are not saved

https://gerrit.wikimedia.org/r/1030061