Page MenuHomePhabricator

Create new NetworkSession mediawiki extension
Closed, ResolvedPublic

Event Timeline

Change 990255 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[integration/config@master] Zuul: Add NetworkSession mediawiki extension

https://gerrit.wikimedia.org/r/990255

Change 990251 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/extensions/NetworkSession@master] Basic extension structure

https://gerrit.wikimedia.org/r/990251

Change 990255 merged by jenkins-bot:

[integration/config@master] Zuul: Add NetworkSession mediawiki extension

https://gerrit.wikimedia.org/r/990255

Mentioned in SAL (#wikimedia-releng) [2024-01-12T22:34:52Z] <James_F> Zuul: [mediawiki/extensions/NetworkSession] Add basic CI for T354976

FWIW MediaWiki-extensions-NetworkAuth is a similar extension, if you are interested in prior art (but it's very outdated and does not use AuthManager).

...actually it's not that similar, it uses IP ranges only, without a token.

Change 990252 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/extensions/NetworkSession@master] Implement NetworkSessionProvider

https://gerrit.wikimedia.org/r/990252

Change 990251 merged by jenkins-bot:

[mediawiki/extensions/NetworkSession@master] Basic extension structure

https://gerrit.wikimedia.org/r/990251

Went through https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment to make sure we've done what's needed:

Localization - The only localization is the extension description, unclear if necessary (or how).

We now have error messages that are returned, so localization is now necessary. I've filled T356438 to have the extension added to translatewiki.net

You could also implement SessionProvider::describeMessage() (or the corresponding i18n message) while you are at it. I forgot about that during code review (it isn't too important) but if you are setting up i18n anyway...

Change 990252 merged by jenkins-bot:

[mediawiki/extensions/NetworkSession@master] Implement NetworkSessionProvider

https://gerrit.wikimedia.org/r/990252

Change 1001035 had a related patch set uploaded (by Zoranzoki21; author: Zoranzoki21):

[mediawiki/extensions/NetworkSession@master] Enable Grunt tests

https://gerrit.wikimedia.org/r/1001035

Change 1001035 merged by jenkins-bot:

[mediawiki/extensions/NetworkSession@master] Enable Grunt tests

https://gerrit.wikimedia.org/r/1001035

Updated the mw.org page with the latest changes, so it's now inline with the repository. I think this is enough to call this ticket complete. T355267 is the task for deploying this extension to the wikis.