Page MenuHomePhabricator

Regression: Active link color is broken on mobile
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • The active internal link is black
  • The active external link is dark blue (#2a4b8d)

What should have happened instead?:

  • Active links should be yellow (#faa700) (as of wmf/1.42.0-wmf.16)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Prod

ACStatusDetails
1T357381#9570859

Event Timeline

Change 1003018 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Restore link active color

https://gerrit.wikimedia.org/r/1003018

It looks like historically Minerva defined @color-link--active: as #faa700 (which is different from the Codex design token) and that was removed in https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/995065/16/resources/mediawiki.less/mediawiki.skin.variables.less#b33

Change 1003018 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Restore link active color

https://gerrit.wikimedia.org/r/1003018

Mabualruz set the point value for this task to 1.

Right now the active link colour is yellow in night mode. It should be a shade of blue.

The active link colour is yellow right now. There's a variable called --color-link--active which is #FAA700. That's where the yellow clicked color is coming from. We spec'd color-progressive--active as #AFB6E9.

I chatted to @JScherer-WMF and clarified that this bug is about the regression from yellow to black. We'll create a new ticket for changing the Minerva color to the standard Codex design token color (which will make it #FAA700)

Edtadros subscribed.

@Jdlrobson, I'm unable to recreate this so I don't know how to validate the fix in Beta.

This was backported so can be QAed in production. I can confirm it's a pass :)

Jdlrobson lowered the priority of this task from Medium to Low.Feb 22 2024, 5:30 PM

Test Result - Prod

Status: ❌ FAIL
Environment: mediawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://m.mediawiki.org/wiki/MediaWiki
Touch/click on an internal link (e.g. "Download")
Touch/click on an external link (e.g. "Wikimedia Developer Portal")
What happens?:

The active internal link is black
The active external link is dark blue (#2a4b8d)
What should have happened instead?:

❌ AC1: Active links should be yellow (#faa700) (as of wmf/1.42.0-wmf.16)
The active internal link shows as yellow, but the active external link does not.

screenshot 560.png (844×391 px, 96 KB)

screenshot 561.png (844×391 px, 96 KB)

I think that's expected (albeit weird). I believe @JScherer-WMF wanted to remove the yellow color. If so does a ticket yet exist? If not could you please create one?

Follow up ticket created in T358516.