Page MenuHomePhabricator

Growth features: Migrate Homepage settings from Special:EditGrowthConfig to Community configuration 2.0
Closed, ResolvedPublic

Description

As part of migrating Special:EditGrowthConfig to the Community configuration 2.0 system, we need to migrate the "Newcomer homepage" section from https://en.wikipedia.org/wiki/Special:EditGrowthConfig to Special:CommunityConfiguration. This task captures that work.

Acceptance Criteria
  • Newcomer hompeage configuration options are moved to Special:CommunityConfiguration/NewcomerHomepage

Event Timeline

This is currently blocked on implementing the agreed-on changes to T357718: Support schema references. Moving to Blocked to reflect that.

Change #1017267 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Community configuration: Add HomepageSchema

https://gerrit.wikimedia.org/r/1017267

Change #1017267 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Community configuration: Add HomepageSchema

https://gerrit.wikimedia.org/r/1017267

testing comment, please disregard

Etonkovidova subscribed.

Tested in eswiki beta and compared with es.Special:EditGrowthConfig.

Issues:
(1) Special:EditGrowthConfig indicates that two fields in Newcomer Homepage are required fields; eswiki beta Especial:CommunityConfiguration/GrowthHomepage doesn't display those fields as required.

eswiki wmf.2eswiki beta
Screen Shot 2024-05-01 at 6.48.19 PM.png (392×1 px, 92 KB)
Screen Shot 2024-05-01 at 6.52.39 PM.png (700×3 px, 126 KB)

(2) ( - could not reproduce it.) If a user attempts to save an empty field Special:EditGrowthConfig or a field with a non-existent page, there will be specific warning and the save fails; eswiki beta Especial:CommunityConfiguration/GrowthHomepage will display

eswiki wmf.2eswiki beta
Screen Shot 2024-05-01 at 4.48.03 PM.png (390×1 px, 55 KB)
Screen Shot 2024-05-01 at 4.48.15 PM.png (414×1 px, 60 KB)
Screen Shot 2024-05-01 at 5.04.28 PM.png (1×1 px, 169 KB)

(3) Special:EditGrowthConfig doesn't allow users without special permission to edit the fields - the fields cannot be edited; eswiki beta Especial:CommunityConfiguration/GrowthHomepage displays the warning to users without proper rights after they submitted the form. The warning message is not specific.

eswiki wmf.2eswiki beta
Screen Shot 2024-05-01 at 6.52.39 PM.png (700×3 px, 126 KB)
Screen Shot 2024-05-01 at 6.53.20 PM.png (904×2 px, 187 KB)

(4) a question to @Urbanecm_WMF
GEHomepageSuggestedEditsIntroLinks has two fields that add links to two different places in eswiki wmf.2 - create "Wikipedia:Asistente para la creación de artículos"is t "Learn more" link in Select types of edits and image "mw:Help:VisualEditor/User_guide/es#Images" to a link in the Help module. It is expected that admins have a good understanding of where such links should go?

(5) (minor) Clicking in the field where a valid page is entered, will display "No results found" which looks confusing since a page does exists. The general Search field doesn't behave like this. See the animated gif below.

Newcomer_page_focus.gif (848×1 px, 174 KB)

Thanks for testing @Etonkovidova 😊

(1) Special:EditGrowthConfig indicates that two fields in Newcomer Homepage are required fields; eswiki beta Especial:CommunityConfiguration/GrowthHomepage doesn't display those fields as required.

eswiki wmf.2eswiki beta
Screen Shot 2024-05-01 at 6.48.19 PM.png (392×1 px, 92 KB)
Screen Shot 2024-05-01 at 6.52.39 PM.png (700×3 px, 126 KB)

This should be resolved with T364504: Community Configuration: optional fields should be indicated with optionalFlag.

(2) ( - could not reproduce it.) If a user attempts to save an empty field Special:EditGrowthConfig or a field with a non-existent page, there will be specific warning and the save fails; eswiki beta Especial:CommunityConfiguration/GrowthHomepage will display

eswiki wmf.2eswiki beta
Screen Shot 2024-05-01 at 4.48.03 PM.png (390×1 px, 55 KB)
Screen Shot 2024-05-01 at 4.48.15 PM.png (414×1 px, 60 KB)
Screen Shot 2024-05-01 at 5.04.28 PM.png (1×1 px, 169 KB)

(3) Special:EditGrowthConfig doesn't allow users without special permission to edit the fields - the fields cannot be edited; eswiki beta Especial:CommunityConfiguration/GrowthHomepage displays the warning to users without proper rights after they submitted the form. The warning message is not specific.

eswiki wmf.2eswiki beta
Screen Shot 2024-05-01 at 6.52.39 PM.png (700×3 px, 126 KB)
Screen Shot 2024-05-01 at 6.53.20 PM.png (904×2 px, 187 KB)

I believe these two could be improved in T363855: Improve validation errors wording and behavior. @Sgs could you correct me if I am mistaken please?

(5) (minor) Clicking in the field where a valid page is entered, will display "No results found" which looks confusing since a page does exists. The general Search field doesn't behave like this. See the animated gif below.

Newcomer_page_focus.gif (848×1 px, 174 KB)

I believe @Sgs you commented the reasoning for this during Estimation/Sprint planning. Is there an engineering task for resolving this?

JFernandez-WMF updated the task description. (Show Details)

Acceptance criteria is crossed out so I will close this as resolved and we can continue with the open questions in other tasks. Feel free to re-open if there's disagreement on this.