Page MenuHomePhabricator

Imagehash toolforge generates broken thumbnail links
Open, Needs TriagePublicBUG REPORT

Description

get_thumbnail_url() is broken as thumbnail url prefix syntax can be also

  • ../1024px-encoded_filename
  • ../lossy-page1-1024px-encoded_filename
  • ../lossy-page2-1024px-encoded_filename
  • ../lossless-page1-1024px-encoded_filename

Current code
https://github.com/Wikimedia-Suomi/ImageHash-Toolforge/blob/main/web/app.py#L73

def get_thumbnail_url(filename, width=220):
    encoded_filename = quote(filename.replace(" ", "_"))
    hash = hashlib.md5(filename.replace(" ", "_").encode()).hexdigest()
    return f"https://upload.wikimedia.org/wikipedia/commons/thumb/{hash[0]}/{hash[0:2]}/{encoded_filename}/{width}px-{encoded_filename}"

Related Objects

StatusSubtypeAssignedTask
OpenZache
OpenBUG REPORTNone

Event Timeline

Zache updated the task description. (Show Details)