Page MenuHomePhabricator

web-auth/webauthn-lib must be upgraded to 4+ for PHP 8 support
Open, HighPublic

Description

The WebAuthn extension requires web-auth/webauthn-lib ~3.3.12, webauthn-lib 3.* requires symfony/process ^3.0|^4.0|^5.0, and symfony/process is not PHP 8 compatible. (webauthn-lib 4.* doesn't seem to require symfony/process at all.) webauthn-lib 4.0 requires PHP 8.1 though, so this is not fulfillable.

Currently breaking CI for backports (e.g. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/1024713 ).

Event Timeline

Change #1024971 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WebAuthn@master] Allow web-auth/webauthn-lib ^4.8.0 as well as ~3.3.12 for PHP 8+

https://gerrit.wikimedia.org/r/1024971

The current version at least seems to work in practice good enough on my PHP 8.2 dev wiki and T325358: Include newer web-auth/webauthn-lib which supports php8.2 (needs newer fgrosse/phpasn1) should have fixed it in CI so I'm not sure why this is failing now.

Webauthn-lib 4.x has a number of breaking changes so supporting both at the same time is non-trivial. And with the PHP 8 requirement on 4.x I don't think we're going to get fully on 4.x for the upcoming 1.42 release since Wikimedia is still on 7.4.

Change #1024723 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WebAuthn@REL1_42] Allow web-auth/webauthn-lib ^4.8.0 as well as ~3.3.12 for PHP 8+

https://gerrit.wikimedia.org/r/1024723