Page MenuHomePhabricator
Create Task
Maniphest T363669

CommunityConfiguration: eswiki beta fatals with Help panel enabled
Closed, ResolvedPublic
Actions

Description

MediaWiki internal error.

Original exception: [Zi9NW1Gb3hCFKqArErIhkAAAABA] /wiki/P%C3%A1gina_principal MediaWiki\Config\ConfigException: Key GEHelpPanelHelpDeskTitle was not found.
Backtrace:
from /srv/mediawiki/php-master/extensions/CommunityConfiguration/src/Provider/WikiPageConfigProvider.php(38)
#0 /srv/mediawiki/php-master/extensions/CommunityConfiguration/src/Access/WikiPageConfigReader.php(128): MediaWiki\Extension\CommunityConfiguration\Provider\WikiPageConfigProvider->get(string)
#1 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HelpPanel.php(196): MediaWiki\Extension\CommunityConfiguration\Access\WikiPageConfigReader->get(string)
#2 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HelpPanelHooks.php(181): GrowthExperiments\HelpPanel::getHelpDeskTitle(MediaWiki\Extension\CommunityConfiguration\Access\WikiPageConfigReader)
#3 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(159): GrowthExperiments\HelpPanelHooks->onBeforePageDisplay(MediaWiki\Output\OutputPage, MediaWiki\Skins\Vector\SkinVector22)
#4 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(945): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#5 /srv/mediawiki/php-master/includes/Output/OutputPage.php(2998): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(MediaWiki\Output\OutputPage, MediaWiki\Skins\Vector\SkinVector22)
#6 /srv/mediawiki/php-master/includes/actions/ActionEntryPoint.php(162): MediaWiki\Output\OutputPage->output(boolean)
#7 /srv/mediawiki/php-master/includes/MediaWikiEntryPoint.php(199): MediaWiki\Actions\ActionEntryPoint->execute()
#8 /srv/mediawiki/php-master/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Exception caught inside exception handler: [Zi9NW1Gb3hCFKqArErIhkAAAABA] /wiki/P%C3%A1gina_principal MediaWiki\Config\ConfigException: Key GEHelpPanelHelpDeskTitle was not found.
Backtrace:
from /srv/mediawiki/php-master/extensions/CommunityConfiguration/src/Provider/WikiPageConfigProvider.php(38)
#0 /srv/mediawiki/php-master/extensions/CommunityConfiguration/src/Access/WikiPageConfigReader.php(128): MediaWiki\Extension\CommunityConfiguration\Provider\WikiPageConfigProvider->get(string)
#1 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HelpPanel.php(196): MediaWiki\Extension\CommunityConfiguration\Access\WikiPageConfigReader->get(string)
#2 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HelpPanelHooks.php(181): GrowthExperiments\HelpPanel::getHelpDeskTitle(MediaWiki\Extension\CommunityConfiguration\Access\WikiPageConfigReader)
#3 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(159): GrowthExperiments\HelpPanelHooks->onBeforePageDisplay(MediaWiki\Output\OutputPage, MediaWiki\Skins\Vector\SkinVector22)
#4 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(945): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#5 /srv/mediawiki/php-master/includes/Output/OutputPage.php(2998): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(MediaWiki\Output\OutputPage, MediaWiki\Skins\Vector\SkinVector22)
#6 /srv/mediawiki/php-master/includes/exception/MWExceptionRenderer.php(187): MediaWiki\Output\OutputPage->output()
#7 /srv/mediawiki/php-master/includes/exception/MWExceptionRenderer.php(106): MWExceptionRenderer::reportHTML(MediaWiki\Config\ConfigException)
#8 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(133): MWExceptionRenderer::output(MediaWiki\Config\ConfigException, integer)
#9 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(237): MWExceptionHandler::report(MediaWiki\Config\ConfigException)
#10 /srv/mediawiki/php-master/includes/MediaWikiEntryPoint.php(221): MWExceptionHandler::handleException(MediaWiki\Config\ConfigException, string)
#11 /srv/mediawiki/php-master/includes/actions/ActionEntryPoint.php(82): MediaWiki\MediaWikiEntryPoint->handleTopLevelError(MediaWiki\Config\ConfigException)
#12 /srv/mediawiki/php-master/includes/MediaWikiEntryPoint.php(205): MediaWiki\Actions\ActionEntryPoint->handleTopLevelError(MediaWiki\Config\ConfigException)
#13 /srv/mediawiki/php-master/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

Details

SubjectRepoBranchLines +/-
Editor: render MediaWiki controls based on schemamediawiki/extensions/CommunityConfigurationmaster+64 -32
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm_WMF created this task.Apr 29 2024, 7:43 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 29 2024, 7:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF triaged this task as High priority.Apr 29 2024, 7:44 AM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 12 (Growth Team)); removed Growth-Team.Apr 29 2024, 7:51 AM

This should be fixed with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1023131. I'll double check.

Urbanecm_WMF added a subscriber: Sgs.Apr 29 2024, 8:06 AM
In T363669#9751985, @Urbanecm_WMF wrote:

This should be fixed with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1023131. I'll double check.

On my end, that Core patch together with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommunityConfiguration/+/1024700 fixes the issue. @Sgs plans to take a look at the Core patch (uploaded by me) sometime today, I'll take a look at the CommunityConfiguration uploaded by @Sgs

gerritbot added a comment.Apr 29 2024, 9:25 AM

Change #1024700 had a related patch set uploaded (by Urbanecm; author: Sergio Gimeno):

[mediawiki/extensions/CommunityConfiguration@master] Editor: render MediaWiki controls based on schema

https://gerrit.wikimedia.org/r/1024700

gerritbot added a project: Patch-For-Review.Apr 29 2024, 9:25 AM

Change #1023131 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] JsonSchemaTrait: Add support for inlined references

https://gerrit.wikimedia.org/r/1023131

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 12 (Growth Team)) board.Apr 29 2024, 9:26 AM
gerritbot added a comment.Apr 29 2024, 11:34 AM

Change #1024700 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Editor: render MediaWiki controls based on schema

https://gerrit.wikimedia.org/r/1024700

Urbanecm_WMF mentioned this in rECOMe61a66e206e9: Editor: render MediaWiki controls based on schema.Apr 29 2024, 11:35 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Apr 29 2024, 12:00 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 12 (Growth Team)) board.Apr 29 2024, 1:28 PM

Should be fixed!

Urbanecm_WMF mentioned this in T363736: Write a regression test for missing defaults.Apr 29 2024, 4:50 PM
Urbanecm_WMF moved this task from Backlog to Migrate Special:EditGrowthConfig on the CommunityConfiguration board.Apr 29 2024, 5:13 PM
Sgs assigned this task to Urbanecm_WMF.Apr 30 2024, 11:55 AM

Assigning to @Urbanecm_WMF for visbility of unclaimed items in the project goal/column and because he worked on the related patches.

Urbanecm_WMF edited projects, added Growth-Team (Sprint 13 (Growth Team)); removed Growth-Team (Sprint 12 (Growth Team)).Apr 30 2024, 7:07 PM
Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Sprint 13 (Growth Team)) board.
Etonkovidova closed this task as Resolved.Tue, May 7, 12:46 AM
Sgs mentioned this in T364056: CommunityConfiguration: saving an empty value for numerical input does not behave correctly.Wed, May 15, 11:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL