Page MenuHomePhabricator

Missing content on discussion tools on Parsoid
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Compare
https://en.wikivoyage.org/wiki/User_Talk%3AAsqueladd?useparsoid=0
and
https://en.wikivoyage.org/wiki/User_Talk%3AAsqueladd?useparsoid=1

What happens?:

The status line of the first post ("Latest comment: 8 years ago by Ikan Kekek in topic Thumb right") is not present on the Parsoid output

What should have happened instead?:

Parsoid should not drop content from rendering

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Observation: changing the order of the Localization and ExecutePostCacheTransformHooks passes (putting "localization" after the hooks) does solve the issue. So as a "temporary fix", this might be an option.

Seems like extension data being dropped during clone is the root cause?

Change #1030124 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Fix the loss of ParserOutput pointer in ContentDOMTransformStages

https://gerrit.wikimedia.org/r/1030124

Change #1030124 merged by jenkins-bot:

[mediawiki/core@master] Fix the loss of ParserOutput pointer in ContentDOMTransformStages

https://gerrit.wikimedia.org/r/1030124

At https://www.mediawiki.org/wiki/Topic:Y4ium5hlsqc0wm2b it was reported that replying using DiscussionTools is also broken when using Parsoid, and I think that problem has the same cause – the data about which comments exist on the page, which is stored using addJsConfigVars, gets lost. Looks the patch above fixes that as well.

Change #1031067 had a related patch set uploaded (by C. Scott Ananian; author: Isabelle Hurbain-Palatin):

[mediawiki/core@wmf/1.43.0-wmf.4] Fix the loss of ParserOutput pointer in ContentDOMTransformStages

https://gerrit.wikimedia.org/r/1031067

Change #1031067 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.4] Fix the loss of ParserOutput pointer in ContentDOMTransformStages

https://gerrit.wikimedia.org/r/1031067

Mentioned in SAL (#wikimedia-operations) [2024-05-14T08:26:53Z] <dcausse@deploy1002> Started scap: Backport for [[gerrit:1031067|Fix the loss of ParserOutput pointer in ContentDOMTransformStages (T364597)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-14T08:29:35Z] <dcausse@deploy1002> dcausse and cscott: Backport for [[gerrit:1031067|Fix the loss of ParserOutput pointer in ContentDOMTransformStages (T364597)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-14T08:43:11Z] <dcausse@deploy1002> Finished scap: Backport for [[gerrit:1031067|Fix the loss of ParserOutput pointer in ContentDOMTransformStages (T364597)]] (duration: 16m 17s)