Page MenuHomePhabricator

CI Blocker: MergeUserTest::testBasicMerge: Error 1054: Unknown column 'bt_address' in 'field list'
Closed, ResolvedPublic

Description

The quibble-vendor-mysql-php74-noselenium pipeline is currently blocked for Translate and TranslationNotifications extension

13:32:22 1) MergeUserTest::testBasicMerge
13:32:22 Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'bt_address' in 'field list'
13:32:22 Function: MergeUser::mergeBlocks
13:32:22 Query: SELECT  bl_id AS `ipb_id`,COALESCE(bt_address, bt_user_text) AS `ipb_address`,bl_timestamp AS `ipb_timestamp`,bt_auto AS `ipb_auto`,bl_anon_only AS `ipb_anon_only`,bl_create_account AS `ipb_create_account`,bl_enable_autoblock AS `ipb_enable_autoblock`,bl_expiry AS `ipb_expiry`,bl_deleted AS `ipb_deleted`,bl_block_email AS `ipb_block_email`,bl_allow_usertalk AS `ipb_allow_usertalk`,bl_parent_block_id AS `ipb_parent_block_id`,bl_sitewide AS `ipb_sitewide`,bl_by_actor AS `ipb_by_actor`,block_by_actor.actor_user AS `ipb_by`,block_by_actor.actor_name AS `ipb_by_text`,comment_bl_reason.comment_text AS `ipb_reason_text`,comment_bl_reason.comment_data AS `ipb_reason_data`,comment_bl_reason.comment_id AS `ipb_reason_cid`,ipb_user  FROM `unittest_block` JOIN `unittest_actor` `block_by_actor` ON ((actor_id=bl_by_actor)) JOIN `unittest_comment` `comment_bl_reason` ON ((comment_bl_reason.comment_id = bl_reason_id))   WHERE ipb_user IN (1,3)   
13:32:22 
13:32:22 
13:32:22 /workspace/src/includes/libs/rdbms/database/Database.php:1203
13:32:22 /workspace/src/includes/libs/rdbms/database/Database.php:1187
13:32:22 /workspace/src/includes/libs/rdbms/database/Database.php:1161
13:32:22 /workspace/src/includes/libs/rdbms/database/Database.php:652
13:32:22 /workspace/src/includes/libs/rdbms/database/Database.php:1350
13:32:22 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:126
13:32:22 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:358
13:32:22 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:730
13:32:22 /workspace/src/extensions/UserMerge/includes/MergeUser.php:133
13:32:22 /workspace/src/extensions/UserMerge/includes/MergeUser.php:312
13:32:22 /workspace/src/extensions/UserMerge/includes/MergeUser.php:59
13:32:22 /workspace/src/extensions/UserMerge/tests/phpunit/MergeUserTest.php:56
13:32:22 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106

See patches:

  1. 1016081: MessageGroupMetadata: Remove unnecessary metadata | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1016081
  2. 1026151: Add call to action to mark page for translations to article headings | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1026151

Event Timeline

abi_ triaged this task as Unbreak Now! priority.May 10 2024, 10:21 AM
abi_ created this task.

Change #1030077 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/UserMerge@master] Use DatabaseBlockStore and new block schema

https://gerrit.wikimedia.org/r/1030077

Now I get

13:48:17 includes/UserMergeHooks.php:13 PhanUndeclaredInterface Class implements undeclared interface \MediaWiki\Extension\UserMerge\Hooks\AccountFieldsHook
13:48:17 includes/UserMergeHooks.php:14 PhanUndeclaredInterface Class implements undeclared interface \MediaWiki\Extension\UserMerge\Hooks\MergeAccountFromToHook
13:48:17 includes/UserMergeHooks.php:15 PhanUndeclaredInterface Class implements undeclared interface \MediaWiki\Extension\UserMerge\Hooks\AccountDeleteTablesHook

See https://integration.wikimedia.org/ci/job/mwext-php74-phan/9483/console. Looks like this is now Echo failing, see https://gerrit.wikimedia.org/g/mediawiki/extensions/Echo/+/9df34c2c7f941d1b95ddc4235a5d1853858c7eca/includes/UserMergeHooks.php#7.

Change #1030170 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/Echo@master] Suppress phan errors caused by UserMerge undeploy

https://gerrit.wikimedia.org/r/1030170

Change #1030170 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Suppress phan errors caused by UserMerge undeploy

https://gerrit.wikimedia.org/r/1030170

Change #1030045 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalBlocking@master] Suppress phan errors caused by UserMerge undeploy

https://gerrit.wikimedia.org/r/1030045

Change #1030045 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Suppress phan errors caused by UserMerge undeploy

https://gerrit.wikimedia.org/r/1030045

Change #1030979 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[integration/config@master] Keep UserMerge phan dependencies for production-deployed extensions

https://gerrit.wikimedia.org/r/1030979

Change #1031068 had a related patch set uploaded (by Jdlrobson; author: Amir Sarabadani):

[mediawiki/extensions/Echo@wmf/1.43.0-wmf.4] Suppress phan errors caused by UserMerge undeploy

https://gerrit.wikimedia.org/r/1031068

tstarling subscribed.

This was fixed.

Change #1030979 merged by jenkins-bot:

[integration/config@master] Keep UserMerge phan dependencies for production-deployed extensions

https://gerrit.wikimedia.org/r/1030979

Change #1031068 abandoned by Hashar:

[mediawiki/extensions/Echo@wmf/1.43.0-wmf.4] Suppress phan errors caused by UserMerge undeploy

Reason:

Fixed by [integration/config@master] Keep UserMerge phan dependencies for production-deployed extensions

https://gerrit.wikimedia.org/r/1030979

https://gerrit.wikimedia.org/r/1031068

Change #1030077 merged by jenkins-bot:

[mediawiki/extensions/UserMerge@master] Use DatabaseBlockStore and new block schema

https://gerrit.wikimedia.org/r/1030077