Page MenuHomePhabricator

No need to export NewValidator
ClosedPublic

Authored by thcipriani on Mar 22 2018, 4:09 PM.

Details

Reviewers
dduvall
Group Reviewers
Release-Engineering-Team
Commits
rGBLBR0595606a314b: No need to export NewValidator
Patch without arc
git checkout -b D1012 && curl -L https://phabricator.wikimedia.org/D1012?download=true | git apply
Summary

It occurred to me while looking at code in another patch that there is
no need to have this function be public.

Test Plan

go test ./...

Diff Detail

Repository
rGBLBR Blubber
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

thcipriani created this revision.Mar 22 2018, 4:09 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptMar 22 2018, 4:09 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani requested review of this revision.Mar 22 2018, 4:09 PM
dduvall accepted this revision.Mar 22 2018, 6:34 PM

Looks good. Tests pass. Binary run against example config works as expected.

This revision is now accepted and ready to land.Mar 22 2018, 6:34 PM
This revision was automatically updated to reflect the committed changes.