Add support for Builder arbitrary build commands
ClosedPublic

Authored by Gilles on May 18 2018, 4:30 PM.

Details

Reviewers
thcipriani
dduvall
Group Reviewers
Release-Engineering-Team
Commits
rGBLBR96de90b36408: Add support for Builder arbitrary build commands
rGBLBR8025356d5506: Add support for Builder arbitrary build commands
Patch without arc
git checkout -b D1054 && curl -L https://phabricator.wikimedia.org/D1054?download=true | git apply

Diff Detail

Repository
rGBLBR Blubber
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Gilles created this revision.May 18 2018, 4:30 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptMay 18 2018, 4:30 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
Gilles requested review of this revision.May 18 2018, 4:30 PM

Booya! Just needs a couple of edits to the inline comments and I think it's good to merge.

config/builder.go
8

Since this was copy/pasted from config/version.go, you might want to adapt it to describe BuilderConfig with more specificity.

16

Same here re: "dependencies flag and requirements" as it still describe the config type from whence it came.

dduvall updated this revision to Diff 2786.May 20 2018, 9:21 AM
  • Example for builder configuration
dduvall accepted this revision.May 20 2018, 9:22 AM
This revision is now accepted and ready to land.May 20 2018, 9:22 AM
This revision was automatically updated to reflect the committed changes.