Page MenuHomePhabricator

refresh: Add catching of RequestException in refresh.php
ClosedPublic

Authored by Krinkle on Jan 11 2020, 12:08 AM.

Details

Reviewers
Krinkle
Commits
R2355:53c36fb14648: refresh: Add catching of RequestException in refresh.php
Patch without arc
git checkout -b D1162 && curl -L https://phabricator.wikimedia.org/D1162?download=true | git apply
Summary

PHP Fatal error: Uncaught GuzzleHttp\Exception\ClientException: Client error:
GET https://performance.wikimedia.org/xenon/logs/daily/.RunJobs.log
resulted in a 404 Not Found response: <title>404 Not Found</title>

PHP Fatal error: Uncaught GuzzleHttp\Exception\ClientException: Client error:
GET https://doc.wikimedia.org/cover-extensions/WikibaseQualityConstraints/clover.xml
resulted in a 404 Not Found response: …

Diff Detail

Repository
R2355 tool-coverme
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3262
Build 5423: arc lint + arc unit

Event Timeline

Krinkle requested review of this revision.Jan 11 2020, 12:08 AM
Krinkle created this revision.
Krinkle accepted this revision.Jan 11 2020, 12:08 AM

It seems the all and rest files are too big to download on-demand. They and up timing out. Fixing the refresh script to make them work.

This revision is now accepted and ready to land.Jan 11 2020, 12:08 AM