Page MenuHomePhabricator

Sync with master via external script
ClosedPublic

Authored by bd808 on Nov 13 2015, 10:10 PM.

Details

Summary

Change the sync-master command to delegate to an externally provisioned
wrapper script that controls the exact rsync command line. This script
can be provisioned in a controlled and audited manner (eg via Puppet) so
that it is guaranteed to be secure enough to allow the script to be
executed as root. Root privileges are needed to ensure that mtimes are
propagated between masters due to unix restrictions mtime modification
by non-owners of directory inodes.

Bug: T117016
Requires: Ided423d063bbd4e0812a27031d6bafba4f14e6ad

Test Plan

cross fingers and hope

Diff Detail

Repository
rMSCA Scap
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bd808 retitled this revision from to Sync with master via external script.
bd808 updated this object.
bd808 edited the test plan for this revision. (Show Details)
bd808 added reviewers: mmodell, demon, thcipriani.
scap/tasks.py
727

this line triggering the lint failure is annoying

scap/tasks.py
727

I agree. Long lines should be allowed, IMO

I think this is ready to go but we need the puppet change to land first.

thcipriani edited edge metadata.
thcipriani added inline comments.
scap/tasks.py
727

Probably slipped in here before we had the linting setup quite correctly. I'll get it fixed (although I don't have any love for pep8 either).

This revision is now accepted and ready to land.Nov 18 2015, 2:29 PM
mpb01:~/projects/wmf/vagrant-scap/scap  (git master $)
bd808$ arc land master-sync
Switched to branch master. Updating branch...
The following commit(s) will be landed:

808f6a0 Automatic merge by 'arc land'
156c174 Sync with master via external script

Switched to branch master-sync. Identifying and merging...
Landing revision 'D48: Sync with master via external script'...
Merging master-sync into master
Already up-to-date.
Pushing change...

Exception: You do not have permission to push to this repository.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
   PUSH FAILED!
Switched back to branch master.
Usage Exception: 'git push' failed! Fix the error and run 'arc land' again.
This revision was automatically updated to reflect the committed changes.