Page MenuHomePhabricator

Install node modules into common local directory
ClosedPublic

Authored by dduvall on Aug 23 2017, 5:16 PM.

Details

Maniphest Tasks
T171632: Fix or remove Blubber's node_modules optimization
Reviewers
thcipriani
mobrovac
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rGBLBR89a5377118df: Install node modules into common local directory
Patch without arc
git checkout -b D757 && curl -L https://phabricator.wikimedia.org/D757?download=true | git apply
Summary

Install node application dependencies into the common unprivileged
directory defined and managed by RunsConfig, and define NODE_PATH
such that node applications will search the directory for modules.

This fixes the optimization of image layers by using the original
location for installed modules instead of performing a subsequent move
of the modules back into the project directory. The latter may or may
not result in an additional fs layer depending on the backing storage,
making the previous install/move method unreliable.

Fixes T171632

Depends on D741, D756

Test Plan

Run go test ./... or arc unit. Build a node application image.

Diff Detail

Repository
rGBLBR Blubber
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dduvall created this revision.Aug 23 2017, 5:16 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptAug 23 2017, 5:17 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
This revision is now accepted and ready to land.Aug 29 2017, 5:59 PM
dduvall updated this revision to Diff 2028.Sep 5 2017, 4:37 PM

Rebased and modified for changes to D741

This revision was automatically updated to reflect the committed changes.