Page MenuHomePhabricator

Add shared lib node module bins to PATH
ClosedPublic

Authored by dduvall on Sep 6 2017, 7:03 PM.

Details

Maniphest Tasks
T175200: Have Blubber adjust PATH so node_module executables are found
Reviewers
thcipriani
mobrovac
hashar
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rGBLBRb25e7c6b661c: Add shared lib node module bins to PATH
Patch without arc
git checkout -b D770 && curl -L https://phabricator.wikimedia.org/D770?download=true | git apply
Summary

For npm run to find executables provided by external dependencies, the
$NODE_PATH/.bin directory must be present in PATH.

Depends on D769

Test Plan

Run go test ./....

Build and run Mathoid's test variant at:

https://gerrit.wikimedia.org/r/#/c/376319/2

Diff Detail

Repository
rGBLBR Blubber
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dduvall created this revision.Sep 6 2017, 7:03 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptSep 6 2017, 7:03 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
mmodell accepted this revision as: mmodell.Sep 6 2017, 7:54 PM
This revision is now accepted and ready to land.Sep 6 2017, 7:54 PM
mobrovac accepted this revision.Sep 7 2017, 9:00 AM
This revision was automatically updated to reflect the committed changes.