Page MenuHomePhabricator

Move error handling to main
ClosedPublic

Authored by thcipriani on Sep 14 2017, 11:08 PM.

Details

Reviewers
dduvall
Group Reviewers
Release-Engineering-Team
Commits
rGBLBR01f3533a0b48: Move error handling to main
Patch without arc
git checkout -b D784 && curl -L https://phabricator.wikimedia.org/D784?download=true | git apply
Summary

Rather than calling log.Fatal in Compile bubble the error up to
main and handle it there.

Test Plan

go test ./...

Diff Detail

Repository
rGBLBR Blubber
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

thcipriani created this revision.Sep 14 2017, 11:08 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptSep 14 2017, 11:08 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
dduvall accepted this revision.Oct 10 2017, 5:53 PM
This revision is now accepted and ready to land.Oct 10 2017, 5:53 PM
This revision was automatically updated to reflect the committed changes.