Page MenuHomePhabricator

Move error handling to main
ClosedPublic

Authored by thcipriani on Sep 14 2017, 11:08 PM.
Referenced Files
Unknown Object (File)
Fri, Mar 17, 9:02 PM
Unknown Object (File)
Sat, Mar 11, 6:54 PM
Unknown Object (File)
Feb 2 2023, 4:43 PM
Unknown Object (File)
Oct 1 2022, 1:22 PM
Unknown Object (File)
Aug 18 2022, 10:22 AM
Unknown Object (File)
Jul 7 2022, 3:07 PM
Subscribers
None

Details

Reviewers
dduvall
Group Reviewers
Release-Engineering-Team
Commits
rGBLBR01f3533a0b48: Move error handling to main
Patch without arc
git checkout -b D784 && curl -L https://phabricator.wikimedia.org/D784?download=true | git apply
Summary

Rather than calling log.Fatal in Compile bubble the error up to
main and handle it there.

Test Plan

go test ./...

Diff Detail

Repository
rGBLBR Blubber
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Oct 10 2017, 5:53 PM
This revision was automatically updated to reflect the committed changes.