Hide the LDAP login form by default, click to show
ClosedPublic
Actions

Authored by mmodell on Oct 20 2017, 9:08 PM.

Details

Maniphest Tasks

T862: Redesign Phabricator login page: LDAP login too prominent; position of MediaWiki SUL login not prominent enough
T963: Make the phabricator OAuth login UI more prominent

Reviewers

Nemo_bis
Qgil
Aklapper
• MZMcBride
• chasemp
Paladox

Patch without arc

git checkout -b D831 && curl -L https://phabricator.wikimedia.org/D831?download=true | git apply

Summary

This hides the LDAP login form but provides a button to toggle it. Here is what it looks like:

Screenshot from 2017-10-20 16-09-04.png (571×571 px, 35 KB)

Fixes T963

Test Plan

Tested locally on my phabricator dev. instance. Tried login page, toggled the ldap form, etc.

Diff Detail

Repository

rPHAB Phabricator

Branch

wmf/stable

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2388
Build 3898: differential-jessie	Jenkins
Build 3897: arc lint + arc unit

Event Timeline

mmodell created this revision.Oct 20 2017, 9:08 PM

Harbormaster failed remote builds in B2386: Diff 2198!Oct 20 2017, 9:09 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/783/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/783/console

mmodell retitled this revision from Hide the LDAP login form by default, click to show This hides the LDAP login form but provides a button to toggle it. to Hide the LDAP login form by default, click to show.Oct 20 2017, 9:10 PM

mmodell edited the summary of this revision. (Show Details)

mmodell mentioned this in T167020: Point support URL for Commons android app to GitHub.

mmodell mentioned this in T963: Make the phabricator OAuth login UI more prominent.Oct 20 2017, 9:20 PM

Paladox accepted this revision.Oct 20 2017, 9:21 PM

This revision is now accepted and ready to land.Oct 20 2017, 9:21 PM

mmodell added a task: T862: Redesign Phabricator login page: LDAP login too prominent; position of MediaWiki SUL login not prominent enough.Oct 20 2017, 9:21 PM

Framawiki awarded a token.Oct 20 2017, 9:42 PM

Krinkle added a subscriber: Krinkle.Oct 21 2017, 2:40 AM

Krinkle added inline comments.

webroot/rsrc/css/application/auth/auth.css
59	Is there a way to make this only apply when JavaScript is enabled? Otherwise the main log in form will be rendered inaccessible. Alternate: The outcome looks good, and if that's what it was already, I wouldn't have known better. But compared to the current state, it seems the main difference from this commit would be adding the wording of "Wikitech/Gerrit" in close proximity to the LDAP form. Perhaps a solution could be to leave the form as-is, but improve the label of this heading? Example:

mmodell added inline comments.Oct 21 2017, 1:12 PM

webroot/rsrc/css/application/auth/auth.css
59	Is there a way to make this only apply when JavaScript is enabled? I will see what I can come up with... Perhaps a solution could be to leave the form as-is, but improve the label of this heading? One of the main purposes is to De-emphasize the LDAP form, so changing the wording would be an improvement but I don't think it would resolve T963