Use dep for dependency management and commit vendor
ClosedPublic

Authored by dduvall on Nov 15 2017, 7:01 PM.

Details

Maniphest Tasks
T180530: Use dep to manage vendor dependencies for blubber
Reviewers
thcipriani
Joe
Group Reviewers
Release-Engineering-Team
Commits
rGBLBR00820cbd6bbc: Use dep for dependency management and commit vendor
Patch without arc
git checkout -b D882 && curl -L https://phabricator.wikimedia.org/D882?download=true | git apply
Summary

Our current lack of dependency management is leading to issues with
Debian packaging and risks inconsistent builds. Let's use dep, the
"official experiment" for go dependency management, and commit the
vendor directory which is small enough following a dep prune.

Fixes T180530
Depends on D881

Test Plan

Run make or go build -v and examine output to ensure use of vendor/
packages.

Diff Detail

Repository
rGBLBR Blubber
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dduvall created this revision.Nov 15 2017, 7:01 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptNov 15 2017, 7:01 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
dduvall updated this revision to Diff 2326.Nov 15 2017, 7:02 PM
dduvall edited the summary of this revision. (Show Details)

Reference task

thcipriani accepted this revision.Nov 16 2017, 8:43 PM

WMF: was able to build a new debian package \o/

This revision is now accepted and ready to land.Nov 16 2017, 8:43 PM
This revision was automatically updated to reflect the committed changes.