(An Untitled Masterwork)
ActivePublic
Actions

Authored by jgleeson on Dec 20 2021, 8:27 PM.

Tags

None

Referenced Files

	F34891013: raw-paste-data.txt
	Dec 20 2021, 8:28 PM

	F34891012: raw-paste-data.txt
	Dec 20 2021, 8:27 PM

Subscribers

None

	- if (
	- $message['validation_action'] === ValidationAction::REVIEW \|\|
	- (
	- $message['validation_action'] === ValidationAction::REJECT &&
	- $message['gateway'] === 'ingenico'
	- )
	- ) {
	- // Leave the pending message for potential capture by the pending
	- // transaction rectifier or manual review - for any gateway, REVIEW
	- // status can be captured. FIXME: Our Ingenico front-end code also
	- // treats REJECT status this way, so we should leave those rows as
	- // well.
	- return false;
	- }

	- return true;
	+
	+ // Leave the pending message for potential capture by the pending
	+ // transaction rectifier or manual review - for any gateway, REVIEW
	+ // status can be captured. FIXME: Our Ingenico front-end code also
	+ // treats REJECT status this way, so we should leave those rows as
	+ // well.
	// payments_final_status is either FAILED or CANCELLED, and it's not
	// because of our fraud filters. Safe to delete any pending row.
	+ return $message['validation_action'] !== ValidationAction::REVIEW && !($message['validation_action'] === ValidationAction::REJECT &&
	+ $message['gateway'] === 'ingenico');

jgleeson edited the content of this paste. (Show Details)

(An Untitled Masterwork)ActivePublicActions