Page MenuHomePhabricator

Move @access public/private/protected qualifiers to PHP 5 keywords
Closed, ResolvedPublic

Description

QuickTemplate in SkinTemplate.php defines a couple of functions as ment to be
private, following pathc will activate this behaviour, but will thou break at
least monobook.


Version: 1.9.x
Severity: enhancement

Details

Reference
bz8000

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:28 PM
bzimport set Reference to bz8000.
bzimport added a subscriber: Unknown Object (MLST).

the breaking patch

Attached:

ayg wrote:

There are lots of things marked @private and @public from when MW was PHP 4, and
all should have the labels transferred to the PHP 5 keyword. In the case of
private/protected, this should only be done if you're really sure that nothing
else anywhere uses the method. "Will break Monobook" isn't remotely acceptable.

Did I understand your problem with this bug correctly? Comment #0 is hard to
understand.

robchur wrote:

*** This bug has been marked as a duplicate of 5176 ***