see attached patch
Version: 1.9.x
Severity: normal
AzaToth | |
Dec 13 2006, 2:39 PM |
F3457: Core.patch | |
Nov 21 2014, 9:29 PM |
see attached patch
Version: 1.9.x
Severity: normal
the patch
some minor cleanup of the code.
attachment CPF-cleanup.patch ignored as obsolete
updated urlFunctions
added funtionallity that in my brain was logical, as the posibillity to build
query string by concatenate all extra parameters, for example
{{localurl:Foo|a=1|b=2|c=3}} to give
index.php?title=Foo&bar=baz&baz&boo
/~azatoth/srcwiki/index.php?title=Foo&a=1&b=2&c=3
attachment Core.patch ignored as obsolete
(In reply to comment #3)
Created an attachment (id=2864) [edit]
updated urlFunctionsadded funtionallity that in my brain was logical, as the posibillity to build
query string by concatenate all extra parameters, for example
{{localurl:Foo|a=1|b=2|c=3}} to give
index.php?title=Foo&bar=baz&baz&boo
/~azatoth/srcwiki/index.php?title=Foo&a=1&b=2&c=3
ment only "index.php?title=Foo&a=1&b=2&c=3", manage to copy a row too much
robchur wrote:
Please don't add major new functions in a patch that's supposed to be a "minor
cleanup" - the two MUST be kept separate for code review reasons.
(Word of advice: The phrase "in my brain, [it] was logical" ALWAYS backfires on
you...)
(In reply to comment #5)
Please don't add major new functions in a patch that's supposed to be a "minor
cleanup" - the two MUST be kept separate for code review reasons.(Word of advice: The phrase "in my brain, [it] was logical" ALWAYS backfires on
you...)
oh, sorry, perhaps you are right, sorry for making you upset, I'll revert it