Page MenuHomePhabricator

Wrap periods after change size in changes lists in a CSS span
Closed, InvalidPublic

Description

If you decide to hide the byte difference from recent changes by using...

.mw-plusminus-pos, .mw-plusminus-neg, .mw-plusminus-null { display: none; }

...the periods that separate it from the surrounding text are still displayed.

Without CSS:

(diff) (hist) . . MyPage; 04:30 . . (-134) . . TheUser (Talk)

With CSS display:none:

(diff) (hist) . . MyPage; 04:30 . .  . . TheUser (Talk)

Expected display with CSS display:none:

(diff) (hist) . . MyPage; 04:30 . . TheUser (Talk)

I have created a patch for this, which I will upload now.


Version: unspecified
Severity: enhancement

Details

Reference
bz8549

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:30 PM
bzimport set Reference to bz8549.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 3038
Patch to move periods inside span tag

attachment test.patch ignored as obsolete

titoxd.wikimedia wrote:

If the periods are moved within the span, then declaring a color for the span
(as done currently on en.wp) will cause the colors to be colored as well.

That's a good point, any suggestions?

How about wrapping the dots in a span tag?

<span class="mw-plusminus-dots"> . . </span>

Created attachment 3039
Patch to wrap periods in span tag

Alternative patch to wrap periods in span tag as described in comment 3.

The previous patch was incomplete (the periods were only removed from one call)
and broken (there was a call that didn't add periods) so I'm obsoleting it.

Attached:

Please can you explain why this is invalid? The problem is there as described.