Page MenuHomePhabricator

fixed strings in double quotes
Closed, DeclinedPublic

Description

Very minor bug:
Looking at the LocalSettings.php produced, one notices a few
$bla="fixed strings in double quotes";
whereas you might as well use
$bla='fixed strings in single quotes';
and save a half a cycle.

E.g., $wgDiff3 = "/usr/bin/diff3";
Might as well write
$wgDiff3 = '/usr/bin/diff3';

Same throughout the other files.


Version: 1.9.x
Severity: minor
OS: Linux
Platform: PC

Details

Reference
bz9191

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:38 PM
bzimport set Reference to bz9191.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

Changing quotes is pointless. Having to alter quote types when you're editing
LocalSettings.php and need to use string interpolation is inconvenient.