Page MenuHomePhabricator

Default settings should not be put in LocalSettings.php on setup
Closed, DeclinedPublic

Description

Author: lcarsdata

Description:
When setting up MediaWiki 1.9.3 the following values were put in
LocalSettings.php however they were identical to the defaults:

  • $wgEnableEmail
  • $wgEnableUserEmail
  • $wgEmailAuthentication
  • $wgDBserver
  • $wgDBtype
  • $wgDBprefix
  • $wgDBmysql5
  • $wgMainCacheType
  • $wgEnableUploads
  • $wgUseTeX
  • $wgLanguageCode
  • $wgDefaultSkin
  • $wgRightsPage (not identical, however similar "" and NULL)
  • $wgRightsUrl (not identical, however similar "" and NULL)
  • $wgRightsText (not identical, however similar "" and NULL)
  • $wgRightsIcon (not identical, however similar "" and NULL)

Having so many useless values makes LocalSettings.php difficult to read and
harder to maintain. Although in some cases it may be useful to have comments
these could be moved to a seperate text file to make reading even easier.


Version: unspecified
Severity: trivial

Details

Reference
bz9318

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:40 PM
bzimport set Reference to bz9318.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

These aren't useless; most of them are settings which people will want to change
out of the box. Having details about the database connection explicitly repeated
in LocalSettings.php is useful for debugging.

It's all about convenience. We aren't repeating the entire DefaultSettings.php
file, we're repeating a small subset which are useful to have in
LocalSettings.php when it comes to changing them.