robchur wrote:

Confirmed in trunk; the links are pointing to nonexistent anchors...it might be
useful to add them.

delirium-wiki wrote:

Looks like a bug in skins/common/wikibits.js. The function tabbedprefs() generates a table of contents by walking the fieldset elements, giving them numbered #prefsection-n internal links, but there's no code anywhere that generates the target anchors.

With the normal style (showing the tabs as tabs), tabbedprefs() registers its own onclick=uncoversection handler within the TOC, so the TOC can basically take care of itself. With the anchor-based version, the TOC isn't standalone, so tabbedprefs() needs to modify the fieldsets to match the TOC it's generating.

Basically the first loop in tabbedprefs() needs to add an anchor element inside of each fieldset it finds with target: '#' + sections[seci].secid. Unfortunately my JavaScript is too rusty to translate that into a patch.

delirium-wiki wrote:

Nevermind, it does do that, setting 'id=prefsection-n' in the fieldset tag (told you my Javascript was rusty), and that does work in a minimal testcase in Firefox, so something trickier must be going on here; apologies for the misdiagnosis.

nicdumz wrote:

I cannot see any proper way to fix this.

( note: functions have moved since to prefs.js )

The anchors do exist, they are inserted by tabbedprefs. However, when clicking on a link, the uncoversection() function is summoned instead of scrolling the window to the proper anchor, overriding the default behavior.

Meaning that *if* we want to scroll down to the anchor after switching tab, we have to add in uncoversection() something like :
window.location.hash = '#' + this.secid;

I tried, this works greatly when CSS is disabled : it scrolls to the right section on clicks.
However, when CSS is enabled, it *also* scrolls to the title of the section. And this is particularly annoying since it hides the tab switcher.

You *can* fix it with the current interface, but it hinders usability for CSS users. If, one day, the Preferences page is redesigned, then we'll probably be able to enhance usability for both type of users; but until then...

The bug is marked as EASY so we should have it OPEN :)

(In reply to comment #0)

Gentlemen, using firefox visit your Special:Preferences.
Now type ALT v y n which means "no styles".

This turns the HTML FIELDSET element helpful index rendering into

• User profile
• Skin
• Files
• Date and time
• Editing
• Recent changes
• Watchlist
• Search
• Misc

However clicking on them does nothing!

Tried with 1.21wmf6 on test2.wikipedia.org with Firefox 17.0.1 and the links work correctly for me without a stylesheet. CLosing as WORKSFORME.