Page MenuHomePhabricator
Create Task
Maniphest T115175

Parentheses around message "flow-post-action-hide-post" are hard-coded
Closed, ResolvedPublic
Actions

Description

Use message "parentheses" instead.

Details

SubjectRepoBranchLines +/-
Don't hardcode English parentheses in one messagemediawiki/extensions/Flowmaster+4 -3
Don't hardcode English parentheses in one messagemediawiki/extensions/Flowmaster+1 -1
Don't hardcode English parentheses in one messagemediawiki/extensions/Flowmaster+1 -1
Customize query in gerrit

Event Timeline

liangent created this task.Oct 10 2015, 3:45 AM
liangent raised the priority of this task from to Needs Triage.
liangent updated the task description. (Show Details)
liangent added a project: StructuredDiscussions.
liangent subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 10 2015, 3:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
liangent added a project: good first task.Nov 27 2015, 4:01 AM
liangent set Security to None.
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 27 2015, 4:01 AM
liangent added a comment.EditedNov 27 2015, 4:03 AM

I haven't looked into the code but this type of bugs usually just need a wfMessage( 'parentheses' ) call in appropriate place. In this case it's easy and I'm tagging it easy for GCI.

Nemo_bis added projects: I18n, Google-Code-In-2015.Jan 7 2016, 8:43 PM
Nemo_bis triaged this task as Medium priority.Jan 8 2016, 7:10 AM
Nemo_bis moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.
gerritbot subscribed.Jan 9 2016, 12:52 PM

Change 263167 had a related patch set uploaded (by Nemo bis):
Don't hardcode English parentheses in one message

https://gerrit.wikimedia.org/r/263167

gerritbot added a project: Patch-For-Review.Jan 9 2016, 12:52 PM
gerritbot added a comment.Jan 10 2016, 10:15 AM

Change 263167 abandoned by IoannisKydonis:
Don't hardcode English parentheses in one message

https://gerrit.wikimedia.org/r/263167

gerritbot added a comment.Jan 10 2016, 10:17 AM

Change 263170 had a related patch set uploaded (by IoannisKydonis):
Don't hardcode English parentheses in one message

https://gerrit.wikimedia.org/r/263170

gerritbot added a comment.Jan 10 2016, 9:13 PM

Change 263243 had a related patch set uploaded (by IoannisKydonis):
Don't hardcode English parentheses in one message

https://gerrit.wikimedia.org/r/263243

gerritbot added a comment.Jan 10 2016, 9:14 PM

Change 263243 abandoned by IoannisKydonis:
Don't hardcode English parentheses in one message

https://gerrit.wikimedia.org/r/263243

gerritbot added a comment.Jan 10 2016, 9:49 PM

Change 263243 restored by IoannisKydonis:
Don't hardcode English parentheses in one message

https://gerrit.wikimedia.org/r/263243

gerritbot added a comment.Jan 10 2016, 10:18 PM

Change 263167 restored by IoannisKydonis:
Don't hardcode English parentheses in one message

https://gerrit.wikimedia.org/r/263167

gerritbot added a comment.Jan 10 2016, 10:19 PM

Change 263243 abandoned by IoannisKydonis:
Don't hardcode English parentheses in one message

https://gerrit.wikimedia.org/r/263243

gerritbot added a comment.Jan 10 2016, 10:26 PM

Change 263167 abandoned by IoannisKydonis:
Don't hardcode English parentheses in one message

https://gerrit.wikimedia.org/r/263167

IoannisKydonis subscribed.Jan 10 2016, 10:36 PM

I uploaded a patch set here: https://gerrit.wikimedia.org/r/#/c/263170/ .

gerritbot added a comment.Jan 12 2016, 10:21 PM

Change 263170 merged by jenkins-bot:
Don't hardcode English parentheses in one message

https://gerrit.wikimedia.org/r/263170

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 12 2016, 11:00 PM
Nemo_bis closed this task as Resolved.Jan 13 2016, 10:11 AM
Nemo_bis assigned this task to IoannisKydonis.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits