Page MenuHomePhabricator

Patch makes EditPage more general
Closed, ResolvedPublic

Description

Author: davemccabe

Description:
the patch

I have made a simple change to EditPage.php in my liquidthreads branch. I would like it tested and put in the trunk to avoid merge headaches, because it's lots of little changes all over. In theory, no behavior should be changed at all, but it would be great if more people could test this.

The change is to use $this->mTitle for GUI stuff and $this->mArticle->getTitle() for content and wikitext stuff. This simple distinction, having the title of the page editpage is accessed from separate from the title of the page actually being edited, makes liquidthreads possible.

Until now, editpage has used $this->mTitle for everything, and this was assigned (and still is) to $wgTitle in construct. But $this->mArticle is an argument to construct, so calling code such as liquidthreads can edit pages other than the main page being accessed.

So test this out please, and if it doesn't break anything, put it in trunk. Thanks!


Version: 1.11.x
Severity: enhancement

Attached:

Details

Reference
bz10033

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:49 PM
bzimport set Reference to bz10033.
bzimport added a subscriber: Unknown Object (MLST).