SMW doesn't display several errors in Imported from
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	May 28 2007, 3:52 AM

Description

Author: info

Description:
Errors arising from [[imported from:=foaf:bad]] or incorrect namespace aren't reported.

Version: unspecified
Severity: normal
URL: http://ontoworld.org/wiki/SMW_unit_test:Test_imported_from

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:50 PM

• bzimport set Reference to bz10047.

info wrote:

I think the fix is just some typos in SMW_Factbox.php, this make the error handling like other code:

+++ . (working copy)
@@ -188,8 +188,8 @@

		if (NULL != $error) {
			$datavalue = SMWDataValue::newTypedValue(new SMWErrorTypeHandler($error),$value);

+ if ($smwgStoreActive) {
+ SMWFactbox::$semdata->addSpecialValue(SMW_SP_IMPORTED_FROM, $datavalue);

			}
			return $datavalue;
		}

I'm not sure about the check for smwgStoreActive but it works for me so I checked this in (SVN revision 22499).

Thanks. There were more of the same typos in earlier versions, but this one escaped my fixes. It should be correct now.