Page MenuHomePhabricator

Some revisions don't load in wikilabels -- old revision info remains.
Closed, ResolvedPublic


From @Woodcutterty

Reporting a possible bug: every now and then, a piece of the workset appears to contain no separate revision. Instead it shows the previously selected revision. Example:

This is the 36th revision shown in a workset:
When I select the 37th revision, I see the same one:
This is the 38th revision in that same workset:
Now when I select the 37th again, I see that revision:

I mark these seemingly empty revisions as 'Unsure?'.

Event Timeline

Halfak raised the priority of this task from to Needs Triage.
Halfak updated the task description. (Show Details)
Halfak moved this task to Parked on the Machine-Learning-Team (Active Tasks) board.
Halfak added subscribers: Halfak, Jeroen_N.

@Woodcutterty, could you help me work out what rev_ids appear in these worksets with problematic revisions? Any rev_id that appears in the workset will help me zero in on the issue.

Just realized that I can see the rev_ids in your screenshots. I'll work with those.

I collected some additionals ones anyway. Figured two id's is probably not a lot to work with.

43869667 - 42942361
44671657 - 42873321
42224678 - 44482225
44630436 - 44195345
43025773 - 44014757
44503664 - 44889391

Every set is the rev_id appearing before and after the one that doesn't load, respectively.

OK. I made some progress. It looks like the problem is that the parent revision was revdeleted. When this happens the API responds in a weird way.

So, we need to handle this weirdness.


Here's a paste of the API response:

         "*":"Couldn't diff to r43712057: content is hidden"
                  "comment":"Wijzigingen door [[Special:Contributions/|]] ([[User talk:|Overleg]]) hersteld tot de laatste versie door [[User:FakirNL|FakirNL]]"

This is now deployed. @Woodcutterty, could you check to see if those revisions load now? You should get an error message that says "No difference" or the dutch equivalent "Geen verschil"

It's working. I'm getting the error message 'Geen verschil' and I can see that the revision was hidden. Thanks again :)

I'm assuming it doesn't really matter how these revisions are labelled? I'm labelling them 'unsure', but I can imagine some users will mark them as damaging and not done in good faith, because "why else would the revision have been hidden".

Indeed. As a matter of practice, it doesn't matter how they are labeled, but it might help if you make sure to make them "unsure". When we use this data to build prediction models, we won't be able to use the deleted revisions anyway.

Halfak set Security to None.