Title->userCan( 'edit' ) may return false positive
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Jun 22 2007, 6:23 AM

Description

Author: nickpj

Description:
Attaching a patch for this against r23108. I haven't applied it in case there's something bleedingly obvious that I am missing.

In includes/Title.php, Title->userCan( 'edit' ) seems to always return true, even if the user has "$wgGroupPermissions['*']['edit'] = false;" in their LocalSettings.php .

This does not seem right, and causes the TalkHere extension to behave incorrectly (always shows an "Add comment" link, even when the user cannot add a comment).

Version: 1.10.x
Severity: normal

Attached:

title-usercan-edit-patch.txt370 BDownload

Details

Reference: bz10332

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:49 PM

• bzimport added a project: MediaWiki-Page-editing.

• bzimport set Reference to bz10332.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Jun 22 2007, 6:23 AM

nickpj wrote:

Added in r23996, marked as resolved.

webboy wrote:

Patch to fix this bug for all actions

There are other actions (like 'delete') affected by this bug. This patch will fix this bug for all actions.

Attached:

bug10332.patch751 BDownload

This will be fixed in my upcoming userCan changes, and I see little immense need to apply the patch before they are applied - seeing as it's a completeness issue rather than an actual software error.

Fixed a while ago.

	F4005: bug10332.patch
	Nov 21 2014, 9:49 PM

Title->userCan( 'edit' ) may return false positiveClosed, ResolvedPublicActions

Description

Details

Event Timeline

Title->userCan( 'edit' ) may return false positive
Closed, ResolvedPublic
Actions