Page MenuHomePhabricator

Sitenotice "dismiss" to be a magic word rather than being hardcoded
Closed, DeclinedPublic

Description

I'd prefer to have the "dismiss" link on sitenotice to be a magic word. That way it can be freely moved around the notice to a better location (such as inside the borders). Sometimes it may be preferable to remove the dismiss link.

I feel the freedom over the dismiss link's location would be helpful.

Also in addition the sitenotice seems to have some unnecessary divs occupying room preventing full usage of the area reserved for sitenotice.


Version: unspecified
Severity: enhancement

Details

Reference
bz10479

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:51 PM
bzimport set Reference to bz10479.
bzimport added a subscriber: Unknown Object (MLST).

I'm going to have to nix this one; the dismiss button is a UI component, not part of the message text, and will need to be in a standard form and location which is consistent across multiple messages.