Page MenuHomePhabricator
Create Task
Maniphest T12672

Make Linker::doEditSectionLink protected instead of private
Closed, ResolvedPublic
Actions

Description

In Linker.php there is a function called doEditSectionLink that creates edit links. It supports some nice hooks for changing the value of the edit link, but doesn't allow for advanced modification like adding a comment link next to the edit link or changing the HTML of the edit link.

Since skins inherit from SkinTemplate which inherits from Skin which inherits from Linker, users could override this function in their skin. However, the function is currently private which apparently prevents it from being overridden. If it were protected instead of private the problem would be solved.

Version: 1.11.x
Severity: enhancement
URL: http://svn.wikimedia.org/svnroot/mediawiki/trunk/phase3/includes/Linker.php

Details

Reference
bz10672

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:50 PM
• bzimport added a project: MediaWiki-Page-editing.
• bzimport set Reference to bz10672.
• bzimport added a subscriber: Unknown Object (MLST).
cneubauer created this task.Jul 23 2007, 9:32 PM
• bzimport added a comment.Jul 23 2007, 9:40 PM

ayg wrote:

I agree, it should be protected. Changed in r24342.

cneubauer added a comment.Jul 24 2007, 6:57 PM

Not exactly sure what I was talking about up there. The hooks do allow you to completely customize the edit links but thanks anyway.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL