Page MenuHomePhabricator

The dutch localisation uses some wrong quotes
Closed, DeclinedPublic

Description

Author: t.w.a.maaswinkel

Description:
When you load any page with the Dutch localisation enabled you get the following error:

Error: missing ) after argument list
Sourcefile: http://localhost/index.php?title=-&action=raw&gen=js
Rule: 16, Column: 44
Sourcecode:
ta['pt-watchlist'] = new Array('l','Pagina's die op mijn volglijst staan');

As you can see there's written "Pagina's" using a single quote, that's also used to tell the javascript it's a string. This should be changed into \' or "Pagina's die op mijn volglijst staan"


Version: 1.9.x
Severity: minor
OS: Windows XP
Platform: PC

Details

Reference
bz10786

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:50 PM
bzimport set Reference to bz10786.
bzimport added a subscriber: Unknown Object (MLST).

It seems to be correct in 1.9.3: http://svn.wikimedia.org/viewvc/mediawiki/tags/REL1_9_3/phase3/languages/messages/MessagesNl.php?view=markup

But the syntax of tooltips/access keys changed in 1.10.0, they are not longer stored in monobook.js. Every tooltip has its own message:
'tooltip-pt-watchlist' => 'Pagina',

http://svn.wikimedia.org/viewvc/mediawiki/tags/REL1_10_1/phase3/languages/messages/MessagesNl.php?view=markup

What else the problem in 1.9.3 is/was, it does not longer exists :-)

t.w.a.maaswinkel wrote:

To bad (one way or another) we can't download the 1.10.1 version from the web... one way or another our filters block that file....

t.w.a.maaswinkel wrote:

Ok, with your help I've found the error and solved it:
at line 1490 it says
ta[\'pt-watchlist\'] = new Array(\'l\',\'Pagina\'s die op mijn volglijst staan\');
this should be
ta[\'pt-watchlist\'] = new Array(\'l\',\'Pagina\\\'s die op mijn volglijst staan\');
Since it will otherwise go wrong when this PHP is printed out as javascript!

robchur wrote:

Not an issue in 1.10.1, nor trunk.