Page MenuHomePhabricator

checkLanguage.php does not find unexisting messages
Closed, ResolvedPublic

Description

checkLanguage.php in the /maintenance/language directory does no longer list translated messages that do not exist in the English message file. That check was useful so it should be restored.


Version: 1.11.x
Severity: normal

Details

Reference
bz11113

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:51 PM
bzimport set Reference to bz11113.
bzimport added a subscriber: Unknown Object (MLST).

After some testing I see that the check is performed when a language is specified by the --lang parameter, but not when using the default language from the wiki installation.

Ah ok, I never tried/used this before. Sorry for closing.

set default lang code before it is used

The problem seems to be that the default language code is not set until after the code is used to get the messages.
This patch for checkLanguage.inc moves the code that sets the default language and default checks to the beginning of the checkLanguage function, so that the language code is set when it is used to get messages.

Attached:

Now this works again. I think it was revision 26721 by Nikerabbit that fixed the problem.