Page MenuHomePhabricator

'Compare selected versions' button is active, but useless, on history page with one revision
Closed, ResolvedPublic


If there's only one version on a page, the history page still has the little "Compare selected verions" buttons at the top and bottom of the list. Of course, since there aren't multiple versions, there's no radio buttons to select revisions with.

Further, if you click the button, it just sends you to the page itself rather than any kind of diff.

The buttons probably should either be disabled or simply not displayed if we know we're outputting a single revision.

Version: 1.11.x
Severity: minor



Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:52 PM
bzimport set Reference to bz11221.
bzimport added a subscriber: Unknown Object (MLST).

Fixed with r28390. Buttons are disabled now for pages with 1 revision only.

In r28688 I've removed the button, as there are no other form elements present either.