Page MenuHomePhabricator

smwfLoadAllMessages has unnecessary argument.
Closed, ResolvedPublic

Description

Function smwfLoadAllMessages has an unnecessary argument
causing a php warning when the function is called.
Here is the resulting html source:

<br />
<b>Warning</b>: Missing argument 1 for smwfLoadAllMessages() in

<b>/.../extensions/SemanticMediaWiki/includes/SMW_GlobalFunctions.php</b> on line

<b>348</b><br />
<!DOCTYPE html PUBLIC "-W3CDTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
...

The argument is not used within the function.
Suggested solutions:

  1. delete it, or
  2. give it a sensitive default value.

This version of SMW was freshly checked out from svn.


Version: unspecified
Severity: trivial
OS: Linux

Details

Reference
bz11237

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:53 PM
bzimport set Reference to bz11237.
bzimport added a subscriber: Unknown Object (MLST).