Page MenuHomePhabricator
Create Task
Maniphest T135008

tab to move focus out of an edit field while an expert or suggester pop up is open should close the pop up
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Fix siteselector not closing after selecting a sitedata-values/value-viewmaster+4 -2
Close suggesters when tabbing out, and reopen when getting focusdata-values/value-viewmaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

JanZerebecki created this task.May 11 2016, 4:26 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 11 2016, 4:26 PM
JanZerebecki mentioned this in T135009: ESC key should only cancel editing instead of first only closing an pop up (suggester or expert).May 11 2016, 4:28 PM
JanZerebecki added a project: Wikidata.
gerritbot subscribed.May 12 2016, 1:57 PM

Change 288394 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Close suggesters when tabbing out, and reopen when getting focus

https://gerrit.wikimedia.org/r/288394

gerritbot added a project: Patch-For-Review.May 12 2016, 1:57 PM
Jan_Dittrich subscribed.May 12 2016, 3:43 PM

Makes sense from the point of usability.

gerritbot added a comment.May 18 2016, 10:58 AM

Change 288394 merged by jenkins-bot:
Close suggesters when tabbing out, and reopen when getting focus

https://gerrit.wikimedia.org/r/288394

JanZerebecki added projects: Wikidata-Sprint-2016-05-10, ValueView.May 18 2016, 1:08 PM
JanZerebecki closed this task as Resolved.May 18 2016, 1:10 PM
JanZerebecki claimed this task.
JanZerebecki moved this task from Proposed to Done on the Wikidata-Sprint-2016-05-10 board.
gerritbot added a comment.Jul 1 2016, 11:22 AM

Change 296886 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix siteselector not closing after selecting a site

https://gerrit.wikimedia.org/r/296886

gerritbot added a comment.Jul 5 2016, 7:25 AM

Change 296886 merged by jenkins-bot:
Fix siteselector not closing after selecting a site

https://gerrit.wikimedia.org/r/296886

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL