Page MenuHomePhabricator
Create Task
Maniphest T13561

invalid case in Wiki.php
Closed, ResolvedPublic
Actions

Description

Author: kelly.lynn.martin

Description:
In includes/Wiki.php, r24207, line 388, the switch admits to the possiblity of "revert" being a valid action, but there is no "revert" method defined on Article. An attempt to fetch a page with action=revert yields a zero-byte page (tested on en.wikipedia.org @2007-10-04 1950Z).

Recommended fix: remove "revert" case from switch.

Version: 1.12.x
Severity: normal

Details

Reference
bz11561

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:00 PM
• bzimport added a project: MediaWiki-General.
• bzimport set Reference to bz11561.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Oct 4 2007, 7:50 PM
• bzimport added a comment.Oct 4 2007, 8:48 PM

robert wrote:

Removes revert case from switch in Wiki.php

This bug is in fact more severe than it first appears, currently, when action=revert is appended to the URL a fatal error results. This patch simply removes the action fixing this bug.

Attached:

revertaction.diff328 BDownload

• bzimport added a comment.Oct 4 2007, 8:54 PM

robchur wrote:

Fixed in r26414.

• brooke added a comment.Oct 7 2007, 8:44 PM

Reverted in r26488, as this of course breaks image reversion, which uses action=revert.

IAlex added a comment.Mar 1 2008, 3:56 PM

Fixed in r31428.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits