Page MenuHomePhabricator

invalid case in Wiki.php
Closed, ResolvedPublic


Author: kelly.lynn.martin

In includes/Wiki.php, r24207, line 388, the switch admits to the possiblity of "revert" being a valid action, but there is no "revert" method defined on Article. An attempt to fetch a page with action=revert yields a zero-byte page (tested on @2007-10-04 1950Z).

Recommended fix: remove "revert" case from switch.

Version: 1.12.x
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:00 PM
bzimport set Reference to bz11561.
bzimport added a subscriber: Unknown Object (MLST).

robert wrote:

Removes revert case from switch in Wiki.php

This bug is in fact more severe than it first appears, currently, when action=revert is appended to the URL a fatal error results. This patch simply removes the action fixing this bug.


Reverted in r26488, as this of course breaks image reversion, which uses action=revert.