Page MenuHomePhabricator

ProofreadPage loads image directly from upload.wikimedia.org
Closed, ResolvedPublic

Description

proofread.js from the ProofreadPage extension directly loads the file http://upload.wikimedia.org/wikipedia/commons/2/2a/Button_category_plus.png . Instead, it should include the file in the extension directory (some other images are already there) and load it from there.

The relevant patch:

  • a/extensions/ProofreadPage/proofread.js

+++ b/extensions/ProofreadPage/proofread.js
@@ -208,7 +208,7 @@ function proofreadpage_default_setup() {

image.width = 23;
image.height = 22;
image.className = "mw-toolbar-editbutton";

+ image.src = wgScriptPath+'/extensions/ProofreadPage/Button_category_plus.png';

image.border = 0;
image.alt = proofreadPageMessageToggleHeaders;
image.title = proofreadPageMessageToggleHeaders;

Version: unspecified
Severity: trivial

Details

Reference
bz12132

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:56 PM
bzimport added a project: ProofreadPage.
bzimport set Reference to bz12132.
bzimport added a subscriber: Unknown Object (MLST).