Edits prevented by AbuseFilter through tux interface is shown as successfully saved
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Glaisher
	Aug 6 2016, 9:19 AM

Description

When a user triggers an abuse filter while editing a translation through tux, the edit is shown as successfully saved even if the the edit was not actually saved.

Details

	Subject	Repo	Branch	Lines +/-
	ext.translate.editor: Improve save failure detection	mediawiki/extensions/Translate	master	+19 -4

Customize query in gerrit

Related Objects

Mentioned In: T142292: Figure out ways to reduce number of edits where the translation unit contains exactly the source text

Event Timeline

Glaisher created this task.Aug 6 2016, 9:19 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2016, 9:19 AM

Glaisher removed a project: AbuseFilter.Aug 6 2016, 9:23 AM

Glaisher mentioned this in T142292: Figure out ways to reduce number of edits where the translation unit contains exactly the source text.Aug 6 2016, 9:27 AM

Glaisher moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.Aug 6 2016, 9:34 AM

During testing, I also noticed that it doesn't error for SpamBlacklist hits either.

Glaisher claimed this task.Aug 7 2016, 3:39 PM

Change 303430 had a related patch set uploaded (by Glaisher):
ext.translate.editor: Improve save failure detection

https://gerrit.wikimedia.org/r/303430

Change 303430 merged by jenkins-bot:
ext.translate.editor: Improve save failure detection