Fix permissions check when displaying "Undelete n edits" tab
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	IAlex
	Dec 29 2007, 7:07 PM

Description

proposed patch for Skin.php and SkinTemplate.php

Actually, to show the tab "Undelete n edits" in toolbar (for Skins that extends SkinTemplates) MediaWiki checks if the user has 'delete' or 'undelete' permissions, but if he doesn't have the 'deletedhistory' permission, he'll get a "Permission error" (strange configuration of $wgGroupPermissions, i know). I also modified Skin.php to display "view and restore n deleted edits" instead of "view n deleted edits" if the user has 'undelete' right as after r28151, the user must have the 'undelete' permission (and not the 'delete' one) to restore pages.

Version: 1.12.x
Severity: minor

Attached:

deleted_versions.patch1016 BDownload

Details

Reference: bz12446

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:57 PM

• bzimport added a project: MediaWiki-User-Interface.

• bzimport set Reference to bz12446.

• bzimport added a subscriber: Unknown Object (MLST).

IAlex created this task.Dec 29 2007, 7:07 PM

Applied in r29129 -- thanks for the patch!

Fix permissions check when displaying "Undelete n edits" tabClosed, ResolvedPublicActions

Description

Details

Event Timeline

Fix permissions check when displaying "Undelete n edits" tab
Closed, ResolvedPublic
Actions