Page MenuHomePhabricator
Create Task
Maniphest T14525

[[MediaWiki:Summary-preview]] should be shown also with « Show changes »
Closed, ResolvedPublic
Actions

Description

Author: gangleri

Description:
Hi!

At this moment [[MediaWiki:Summary-preview]] containing « Preview of edit summary: » is shown when « Show changes » ( [[MediaWiki:Showpreview]] ) is clicked / pressed. but not if « Show changes » ( [[MediaWiki:Showdiff]] ) is clicked / pressed.

enhancement request:

« Preview of edit summary: » should be available in both cases; if possible also in connection with « Live preview » ( [[MediaWiki:Showlivepreview]] ) .

Best regards Reinhardt [[user:Gangleri]]

Version: unspecified
Severity: enhancement

Details

Reference
bz12525

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:01 PM
• bzimport added a project: MediaWiki-Page-editing.
• bzimport set Reference to bz12525.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Jan 6 2008, 4:10 AM
• brooke added a comment.Jan 7 2008, 7:03 PM

Not a preview, so it doesn't say preview.

• bzimport added a comment.Jan 7 2008, 8:37 PM

gangleri wrote:

(In reply to comment #1)

Not a preview, so it doesn't say preview.

Dear Brion, if you are fixing dozens of [[eroneous_nr_nn|pipe]] to [[correct_nr_nn|pipe]] the only way to verify the changes you made is the « Show changes » . The same applies for changes in the <includeonly>...</includeonly> parts of templates which do not display in preview.

• bzimport added a comment.Mar 6 2009, 8:20 PM

dotcom wrote:

Often I'm making changes to a page with intricate code, and the best way to see what I've done is to click "Show changes" instead of "Show preview". If I want to see a preview of my edit summary, however, I have to then click "Show preview". This is tedious not only because it requires a second step but also because if the page is long I now have to scroll all the way to the bottom to double-check that my summary is rendered correctly.

It would be very convenient if the summary preview were displayed on both "Show preview" and "Show changes", thus saving a step (and eliminating an unnecessary rendering of the page content itself).

• bzimport added a comment.Mar 6 2009, 8:29 PM

dotcom wrote:

Implements the feature

The attachment is based on r48050 and implements the feature as described in the above comment.

Attached:

EditPage_r48050.diff1 KBDownload

Tobias added a comment.Aug 17 2009, 2:36 PM

Done in r55184.
Please note that I committed the code change before noticing this bug report. I didn't know about brions objections.
Nevertheless I think summary preview on "Show changes" is useful because:

  • "Show preview" may load slowly on large pages; if you do only small changes (fixing typos), you don't want to preview the whole page. "Show changes" usually is faster and you instantly see your changes (with "Show preview" you have to search for the content you modified).
  • If you undo changes your main focus is on the edit summary (where you should justify your revert), not the content itself.
  • We want to encourage users to check their changes and their summary. Forcing them to click "Show changes" _and_ "Show preview" to check the content and the summary is not user friendly.
  • Summary preview takes almost no space (so there isn't really a loss if the user doesn't care about the summary).
IAlex added a comment.Aug 24 2009, 8:38 PM

Marking bug as FIXED since r55184 is now marked as "ok".

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits