Invalid XHTML rendered during edit conflict
Closed, ResolvedPublic

Description

Author: willemo

Description:
The following HTML fragment is rendered during an edit conflict:

<textarea tabindex=6 id='wpTextbox2' name="wpTextbox2" rows='25' cols='80' wrap='virtual'>

Two issues:

  • tabindex attributes lacks quotes
  • wrap='virtual' seems to be invalid XHTML according to the XHTML check of validator.w3.org

Probably the following line in EditPage.php needs to be changed from:

$wgOut->addHTML( "<textarea tabindex=6 id='wpTextbox2' name=\"wpTextbox2\" rows='{$rows}' cols='{$cols}' wrap='virtual'>"

into:

$wgOut->addHTML( "<textarea tabindex='6' id='wpTextbox2' name=\"wpTextbox2\" rows='{$rows}' cols='{$cols}'>"

(not sure about wrap, though)

I admit this is quite an unusual use case. Error is found in svn trunk yesterday.


Version: unspecified
Severity: trivial

bzimport added a subscriber: wikibugs-l.
bzimport set Reference to bz12553.
bzimport created this task.Via LegacyJan 8 2008, 7:29 PM
brion added a comment.Via ConduitJan 9 2008, 1:09 AM

Fixed in r29474.

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.