Page MenuHomePhabricator
Create Task
Maniphest T150499

5.3.0 (993) Saving article from 3d touch action doesn't update Saved page list
Closed, ResolvedPublic
Actions

Description

iPhone 6S, iOS 10.2 beta 2 build

Steps to reproduce:

  1. Press (3d touch) any article (in search result or any of the main tabs)
  2. Tap the Save action, and the peek view is dismissed
  3. Go to the Saved tab

Expected behavior: Article pressed in step 1 above should appear at top of Saved list
Actual: Saved list looks as it did before

This is also broken with Unsaving (3d press a cell in the Saved list, tap "Unsave" action and the item is not removed).

I also tried background and cold restarting the app, and verifying the Saved list still had not updated.

Event Timeline

• JMinor created this task.Nov 11 2016, 12:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2016, 12:35 AM
• JMinor triaged this task as Medium priority.Nov 11 2016, 12:35 AM
• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.3.0-Welsh-Dragon board.
JoeWalsh subscribed.EditedNov 11 2016, 11:24 AM

For me, after clean install of the latest Beta - saving wouldn't work from feed cards or the article view. The button wouldn't change to blue and the list wasn't updated. After force-quit and re-open, saving worked again.

[Edit] just tried another clean install and couldn't repro. Also can't repro the 3d touch issue. The common thread seems to be "save for later sporadically stops working entirely"

JoeWalsh claimed this task.Nov 14 2016, 7:35 PM
JoeWalsh moved this task from Ready for Development to Needs Code Review on the iOS-app-v5.3.0-Welsh-Dragon board.
JoeWalsh moved this task from Needs Code Review to Doing on the iOS-app-v5.3.0-Welsh-Dragon board.
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Nov 14 2016, 7:47 PM
• JMinor moved this task from Doing to Needs Testing Criteria on the iOS-app-v5.3.0-Welsh-Dragon board.Nov 16 2016, 8:19 PM
• JMinor moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v5.3.0-Welsh-Dragon board.Nov 17 2016, 7:22 PM

Testing: follow the steps to reproduce and check that the Expected behavior works as described.

Nicholas.tsg subscribed.Nov 17 2016, 10:00 PM

Tested on iOS 10.0.1 (iPhone 6S) and Wikipedia app 5.3.0 (998). This is fixed as shown in the video of my testing

T150499.MOV11 MBDownload
- the Saved page list now updates as expected.

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.3.0-Welsh-Dragon board.Nov 17 2016, 10:01 PM
• JMinor closed this task as Resolved.Nov 18 2016, 7:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL