Page MenuHomePhabricator
Create Task
Maniphest T164833

Cumin: allow to specify successful exit codes
Closed, ResolvedPublic
Actions

Description

Right now Cumin consider successful any command that exits with 0 exit code, any other exit code is considered a failure.
Allow to override this default by specifying a list of successful exit codes for each command.

My intention is to add it to the library for now, and evaluate if it could be useful also for the standard CLI usage.

Details

SubjectRepoBranchLines +/-
ClusterShell: allow to specify exit codes per Commandoperations/software/cuminmaster+17 -16
Transports: allow to specify exit codes per Commandoperations/software/cuminmaster+137 -26
Transports: allow to specify a timeout per Commandoperations/software/cuminmaster+87 -34
Transports: use Command class for commandsoperations/software/cuminmaster+49 -25
Transports: add Command classoperations/software/cuminmaster+100 -0
Transports: move BaseWorker helper methods to module functionsoperations/software/cuminmaster+88 -43
Customize query in gerrit

Related Objects

Event Timeline

Volans created this task.May 9 2017, 1:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2017, 1:20 PM
Volans moved this task from Backlog to In Progress on the SRE-tools board.May 9 2017, 1:20 PM
gerritbot subscribed.May 9 2017, 2:41 PM

Change 352841 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: move BaseWorker helper methods to module functions

https://gerrit.wikimedia.org/r/352841

gerritbot added a project: Patch-For-Review.May 9 2017, 2:41 PM

Change 352842 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: add Command class

https://gerrit.wikimedia.org/r/352842

gerritbot added a comment.May 9 2017, 2:41 PM

Change 352843 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: use Command class for commands

https://gerrit.wikimedia.org/r/352843

gerritbot added a comment.May 9 2017, 2:41 PM

Change 352844 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: allow to specify a timeout per Command

https://gerrit.wikimedia.org/r/352844

gerritbot added a comment.May 9 2017, 2:41 PM

Change 352845 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: allow to specify exit codes per Command

https://gerrit.wikimedia.org/r/352845

Volans moved this task from In Progress to In Code Review on the SRE-tools board.May 9 2017, 2:53 PM
gerritbot added a comment.May 9 2017, 8:22 PM

Change 352892 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] ClusterShell: allow to specify exit codes per Command

https://gerrit.wikimedia.org/r/352892

gerritbot added a comment.May 16 2017, 9:57 AM

Change 352841 merged by jenkins-bot:
[operations/software/cumin@master] Transports: move BaseWorker helper methods to module functions

https://gerrit.wikimedia.org/r/352841

gerritbot added a comment.May 17 2017, 8:15 AM

Change 352842 merged by jenkins-bot:
[operations/software/cumin@master] Transports: add Command class

https://gerrit.wikimedia.org/r/352842

gerritbot added a comment.May 17 2017, 8:18 AM

Change 352843 merged by jenkins-bot:
[operations/software/cumin@master] Transports: use Command class for commands

https://gerrit.wikimedia.org/r/352843

gerritbot added a comment.May 17 2017, 11:09 AM

Change 352844 merged by jenkins-bot:
[operations/software/cumin@master] Transports: allow to specify a timeout per Command

https://gerrit.wikimedia.org/r/352844

gerritbot added a comment.May 29 2017, 8:53 AM

Change 352845 merged by jenkins-bot:
[operations/software/cumin@master] Transports: allow to specify exit codes per Command

https://gerrit.wikimedia.org/r/352845

gerritbot added a comment.May 29 2017, 8:58 AM

Change 352892 merged by jenkins-bot:
[operations/software/cumin@master] ClusterShell: allow to specify exit codes per Command

https://gerrit.wikimedia.org/r/352892

Volans closed this task as Resolved.May 29 2017, 11:10 AM
Volans moved this task from In Code Review to Done on the SRE-tools board.
Volans removed a project: Patch-For-Review.
Aklapper edited projects, added Cumin; removed SRE-tools.May 10 2023, 11:15 AM
Volans mentioned this in rCUMIN35cb23f10fdb: ClusterShell: allow to specify exit codes per Command.May 25 2023, 5:56 PM
Volans mentioned this in rCUMIN0df1c6fd0d97: Transports: allow to specify a timeout per Command.
Volans mentioned this in rCUMIN343fa44f0092: Transports: allow to specify exit codes per Command.
Volans mentioned this in rCUMIN6f9da52b29aa: Transports: use Command class for commands.
Volans mentioned this in rCUMIN4d77befcf3f0: Transports: add Command class.
Volans mentioned this in rCUMIN3fe993cda383: Transports: move BaseWorker helper methods to module functions.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits